[webkit-changes] [WebKit/WebKit] b73f45: Background image takes up very large space at the ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b73f454bc7574eec1bbecc93a236187a2a9afcba
      https://github.com/WebKit/WebKit/commit/b73f454bc7574eec1bbecc93a236187a2a9afcba
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-08-23 (Fri, 23 Aug 2024)

  Changed paths:
    A LayoutTests/fast/dynamic/static-pos-compute-when-float-is-present-fail-expected.html
    A LayoutTests/fast/dynamic/static-pos-compute-when-float-is-present-fail.html
    M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp

  Log Message:
  -----------
  Background image takes up very large space at the top of a page display on cambridge.org
https://bugs.webkit.org/show_bug.cgi?id=278565
<rdar://130888629>

Reviewed by Antti Koivisto.

We can't run "setOutOfFlowChildNeedsStaticPositionLayout" type of layout when floats are present (see comment for more info).

* LayoutTests/fast/dynamic/static-pos-compute-when-float-is-present-fail-expected.html: Added.
* LayoutTests/fast/dynamic/static-pos-compute-when-float-is-present-fail.html: Added.
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::attachToRenderElementInternal): The only change here is to introduce an additional condition on when we _can't_ run such simplified layout (renderBlock->containsFloats())

Canonical link: https://commits.webkit.org/282673@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications