[webkit-changes] [WebKit/WebKit] 6b8f14: [SVG2] getPointAtLength should throw exception whe...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6b8f14839b0719d27956f717e132e9055dad7510
      https://github.com/WebKit/WebKit/commit/6b8f14839b0719d27956f717e132e9055dad7510
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-08-23 (Fri, 23 Aug 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-03-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-04-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-05-expected.txt
    M LayoutTests/svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html
    M Source/WebCore/svg/SVGPathElement.cpp

  Log Message:
  -----------
  [SVG2] getPointAtLength should throw exception when "path" is empty and renderable display type

https://bugs.webkit.org/show_bug.cgi?id=268594
rdar://122574451

Reviewed by Simon Fraser.

This patch aligns WebKit with Gecko / Firefox, Blink / Chromium and Web-Specification [1]:

[1] https://svgwg.org/svg2-draft/types.html#InterfaceSVGGeometryElement

NOTE: SVGPathElement interface with SVGGeometryElement.

This patch aligns WebKit to throw exception in case of "path" being empty
(not being able to compute the total length of the path).

"If current element is a non-rendered element, and the UA is not able to compute the total length
of the path, then throw an InvalidStateError."

* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-03-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-04-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-05-expected.txt:
* LayoutTests/svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html:
* Source/WebCore/svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::getPointAtLength const):

Canonical link: https://commits.webkit.org/282665@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications