[webkit-changes] [WebKit/WebKit] 1b69cd: Ignore push events from push subscriptions without...

bnham noreply at github.com
Thu Aug 22 14:33:52 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b69cdebb4f8823d98413eeaa1e19e6efd121ebb
      https://github.com/WebKit/WebKit/commit/1b69cdebb4f8823d98413eeaa1e19e6efd121ebb
  Author: Ben Nham <nham at apple.com>
  Date:   2024-08-22 (Thu, 22 Aug 2024)

  Changed paths:
    M Source/WebKit/webpushd/WebPushDaemon.h
    M Source/WebKit/webpushd/WebPushDaemon.mm

  Log Message:
  -----------
  Ignore push events from push subscriptions without appropriate permissions
https://bugs.webkit.org/show_bug.cgi?id=278530
rdar://131367393

Reviewed by Brady Eidson.

Now that we've moved push and notification permission management into webpushd on iOS, we should
avoid processing push events from subscriptions without the appropriate permissions.

This commit also mentions rdar://134509619, which would make it so that we don't get push events
from clips without the appropriate permissions in the first place. We cannot implement that right
now without some work from other teams.

* Source/WebKit/webpushd/WebPushDaemon.h:
* Source/WebKit/webpushd/WebPushDaemon.mm:
(WebPushD::platformNotificationCenterBundleIdentifier):
(WebPushD::WebPushDaemon::handleIncomingPush):
(WebPushD::WebPushDaemon::handleIncomingPushImpl):

Canonical link: https://commits.webkit.org/282634@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list