[webkit-changes] [WebKit/WebKit] 5bb700: Remove TestRunner::installStatisticsDidScanDataRec...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5bb70059d37c2f0ef7b26cf2e26be06054eb5572
      https://github.com/WebKit/WebKit/commit/5bb70059d37c2f0ef7b26cf2e26be06054eb5572
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-08-22 (Thu, 22 Aug 2024)

  Changed paths:
    M LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion-expected.txt
    M LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion.html
    M LayoutTests/http/tests/resourceLoadStatistics/prune-statistics.html
    M LayoutTests/http/tests/resourceLoadStatistics/user-interaction-in-cross-origin-sub-frame.html
    M LayoutTests/http/tests/webAPIStatistics/canvas-read-and-write-data-collection.html
    M LayoutTests/http/tests/webAPIStatistics/font-load-data-collection.html
    M LayoutTests/http/tests/webAPIStatistics/navigator-functions-accessed-data-collection.html
    M LayoutTests/http/tests/webAPIStatistics/screen-functions-accessed-data-collection.html
    M LayoutTests/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html
    M LayoutTests/http/tests/websocket/resources/localhost-websocket-connect.html
    M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp
    M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h
    M Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp
    M Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkProcess.h
    M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
    M Source/WebKit/NetworkProcess/NetworkSession.cpp
    M Source/WebKit/NetworkProcess/NetworkSession.h
    M Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp
    M Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in
    M Source/WebKit/UIProcess/WebProcessProxy.cpp
    M Source/WebKit/UIProcess/WebProcessProxy.h
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
    M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
    M Tools/WebKitTestRunner/TestController.cpp
    M Tools/WebKitTestRunner/TestController.h
    M Tools/WebKitTestRunner/TestInvocation.cpp

  Log Message:
  -----------
  Remove TestRunner::installStatisticsDidScanDataRecordsCallback
https://bugs.webkit.org/show_bug.cgi?id=278508
rdar://134462116

Reviewed by Pascoe.

It stores state in the injected bundle and doesn't work with site isolation.
With some reordering callbacks after awaits, we can get the functionality to be tested
at equivalent times.  When it's gone, we can remove a lot of piping needed to support it.

* LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion-expected.txt:
* LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion.html:
* LayoutTests/http/tests/resourceLoadStatistics/prune-statistics.html:
* LayoutTests/http/tests/resourceLoadStatistics/user-interaction-in-cross-origin-sub-frame.html:
* LayoutTests/http/tests/webAPIStatistics/canvas-read-and-write-data-collection.html:
* LayoutTests/http/tests/webAPIStatistics/font-load-data-collection.html:
* LayoutTests/http/tests/webAPIStatistics/navigator-functions-accessed-data-collection.html:
* LayoutTests/http/tests/webAPIStatistics/screen-functions-accessed-data-collection.html:
* LayoutTests/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html:
* LayoutTests/http/tests/websocket/resources/localhost-websocket-connect.html:
* Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::ResourceLoadStatisticsStore::processStatisticsAndDataRecords):
(WebKit::ResourceLoadStatisticsStore::grandfatherExistingWebsiteData):
(WebKit::ResourceLoadStatisticsStore::setNotifyPagesWhenDataRecordsWereScanned): Deleted.
* Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
* Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):
(WebKit::WebResourceLoadStatisticsStore::registrableDomainsWithWebsiteData):
(WebKit::WebResourceLoadStatisticsStore::setNotifyPagesWhenDataRecordsWereScanned): Deleted.
(WebKit::WebResourceLoadStatisticsStore::notifyResourceLoadStatisticsProcessed): Deleted.
* Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):
(WebKit::NetworkProcess::setNotifyPagesWhenDataRecordsWereScanned): Deleted.
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::registrableDomainsWithWebsiteData):
(WebKit::NetworkSession::notifyResourceLoadStatisticsProcessed): Deleted.
* Source/WebKit/NetworkProcess/NetworkSession.h:
* Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreSetStatisticsNotifyPagesWhenDataRecordsWereScanned): Deleted.
* Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::setNotifyPagesWhenDataRecordsWereScanned): Deleted.
(WebKit::NetworkProcessProxy::notifyResourceLoadStatisticsProcessed): Deleted.
(WebKit::NetworkProcessProxy::notifyWebsiteDataScanForRegistrableDomainsFinished): Deleted.
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::notifyPageStatisticsAndDataRecordsProcessed): Deleted.
(WebKit::WebProcessProxy::notifyWebsiteDataScanForRegistrableDomainsFinished): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setNotifyPagesWhenDataRecordsWereScanned): Deleted.
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:
(WebKit::WebResourceLoadObserver::scheduleNotificationIfNeeded):
(WebKit::WebResourceLoadObserver::updateCentralStatisticsStore):
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Deleted.
(WTR::TestRunner::statisticsDidScanDataRecordsCallback): Deleted.
(WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned): Deleted.
* Tools/WebKitTestRunner/TestController.h:
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

Canonical link: https://commits.webkit.org/282626@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications