[webkit-changes] [WebKit/WebKit] 7f781b: [Grid] Start considering grid item logical min wid...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f781b9a53048a92db4a8db4f3be77b2180adf43
      https://github.com/WebKit/WebKit/commit/7f781b9a53048a92db4a8db4f3be77b2180adf43
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2024-08-22 (Thu, 22 Aug 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    R LayoutTests/fast/css-grid-layout/grid-intrinsic-maximums-expected.html
    R LayoutTests/fast/css-grid-layout/grid-intrinsic-maximums.html
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp

  Log Message:
  -----------
  [Grid] Start considering grid item logical min width when computing inline size contribution.
https://bugs.webkit.org/show_bug.cgi?id=260287
rdar://113984636

Reviewed by Alan Baradlay.

GridTrackSizingAlgorithm::minContentForGridItem is supposed to compute
the min content contribution for the grid item which is supposed to
take into consideration the grid item's minimum size property in the
appropriate axis.

It currently does not do that so this patch is a first step towards that
by taking into consideration the minimum logical width if it is either
fixed or max-content.

The grid-intrinsic-maximums test was testing the min-width: max-content
case specifically and had 2 different versions: one from WPT and one
in fast/css-grid-layout. We were passing the latter but the test
expectations were incorrect while the WPT was ok. So I deleted the one
in fast/css-grid-layout since they would otherwise be the same.

* LayoutTests/TestExpectations:
* LayoutTests/fast/css-grid-layout/grid-intrinsic-maximums-expected.html: Removed.
* LayoutTests/fast/css-grid-layout/grid-intrinsic-maximums.html: Removed.
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithmStrategy::minContentForGridItem const):

Canonical link: https://commits.webkit.org/282616@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications