[webkit-changes] [WebKit/WebKit] f4ec1a: REGRESSION(282012 at main): [GTK] WebKitWebProcess AS...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f4ec1a336d24f155c64875c0bae9c25042ad0b70
      https://github.com/WebKit/WebKit/commit/f4ec1a336d24f155c64875c0bae9c25042ad0b70
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-08-22 (Thu, 22 Aug 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/PlatformDisplay.cpp
    M Source/WebCore/platform/graphics/PlatformDisplay.h
    M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp

  Log Message:
  -----------
  REGRESSION(282012 at main): [GTK] WebKitWebProcess ASSERT in WebCore::PlatformDisplay::sharedDisplay
https://bugs.webkit.org/show_bug.cgi?id=278516

Reviewed by Miguel Gomez.

Since 282012 at main the PlatformDisplay is not created unconditionally,
for example when env var WEBKIT_DISABLE_DMABUF_RENDERER is set we don't
create it. This patch adds PlatformDisplay::sharedDisplayIfExists() that
is used in deinitializeGStreamer() to clear the platform display only
whe it was created.

* Source/WebCore/platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::sharedDisplayIfExists):
* Source/WebCore/platform/graphics/PlatformDisplay.h:
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::deinitializeGStreamer):

Canonical link: https://commits.webkit.org/282613@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications