[webkit-changes] [WebKit/WebKit] 0f73fd: [WebGPU] Change checkedSum to use uint32_t rather ...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f73fd29f852607bb7c19897ec79c08ac574025d
      https://github.com/WebKit/WebKit/commit/0f73fd29f852607bb7c19897ec79c08ac574025d
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-08-21 (Wed, 21 Aug 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm

  Log Message:
  -----------
  [WebGPU] Change checkedSum to use uint32_t rather than uint64_t in RenderBundleEncoder
https://bugs.webkit.org/show_bug.cgi?id=278082
rdar://132393945

Reviewed by Dan Glastonbury.

It’s unclear from the specification https://www.w3.org/TR/webgpu/#dom-gpurendercommandsmixin-draw that we should not allow for these two values to exceed uint32_max when the buffer size exceeds 4GB

The specification and Metal allow us to create buffers exceeding 4GB, though we never do so in practice.

Change these to uint32_t as NSUInteger is 32-bits on some platforms.

* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::runVertexBufferValidation):

Canonical link: https://commits.webkit.org/282590@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications