[webkit-changes] [WebKit/WebKit] 04aa45: Crash in `FrameLoader::checkLoadCompleteForThisFrame`

Charlie Wolfe noreply at github.com
Wed Aug 21 12:33:07 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 04aa45e3bbf8da66a921f7ad96568aa444809ef6
      https://github.com/WebKit/WebKit/commit/04aa45e3bbf8da66a921f7ad96568aa444809ef6
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-08-21 (Wed, 21 Aug 2024)

  Changed paths:
    M Source/WebCore/loader/FrameLoader.cpp

  Log Message:
  -----------
  Crash in `FrameLoader::checkLoadCompleteForThisFrame`
https://bugs.webkit.org/show_bug.cgi?id=278468
rdar://134070948

Reviewed by Ryosuke Niwa.

An unneeded strong reference is held on `document` in the lambda passed to
`DataDetection::detectContentInFrame`. Remove it to avoid destroying `document` on a background thread.

* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

Canonical link: https://commits.webkit.org/282572@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list