[webkit-changes] [WebKit/WebKit] 8c521f: [Writing Tools] iOS: Selection should be hidden wh...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c521f3355c750400b7344a99e0e6221867ad0e2
      https://github.com/WebKit/WebKit/commit/8c521f3355c750400b7344a99e0e6221867ad0e2
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-08-21 (Wed, 21 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
    M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
    M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm
    M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
    M Source/WebKit/UIProcess/PageClient.h
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Source/WebKit/UIProcess/mac/WKTextAnimationManager.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKit/WebKitSwift/TextAnimation/TextAnimationManager.swift
    M Source/WebKit/WebKitSwift/TextAnimation/WKSTextAnimationSourceDelegate.h

  Log Message:
  -----------
  [Writing Tools] iOS: Selection should be hidden when pondering effect begins, stay hidden until all animations complete
https://bugs.webkit.org/show_bug.cgi?id=278144
rdar://133427551

Reviewed by Aditya Keerthi.

Apply the same logic as was previously done on macOS to ensure the selection is cleared during the animation.

Also, refactor the previously-macOS specific logic from WebViewImpl into WKWebView.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView compositionSession:didReceiveText:replacementRange:inContext:finished:]):
(-[WKWebView writingToolsSession:didReceiveAction:]):
(-[WKWebView _didEndPartialIntelligenceTextPonderingAnimation]):
(-[WKWebView _intelligenceTextPonderingAnimationIsComplete]):
(-[WKWebView _addTextAnimationForAnimationID:withData:]):
(-[WKWebView _removeTextAnimationForAnimationID:]):
(-[WKWebView _enableSourceTextAnimationAfterElementWithID:]):
(-[WKWebView _enableFinalTextAnimationForElementWithID:]):
(-[WKWebView _disableTextAnimationWithUUID:]):
(-[WKWebView _enableTextIndicatorStylingAfterElementWithID:]):
(-[WKWebView _enableTextIndicatorStylingForElementWithID:]):
(-[WKWebView _disableTextIndicatorStylingWithUUID:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::didEndPartialIntelligenceTextPonderingAnimation):
(WebKit::PageClientImplCocoa::intelligenceTextPonderingAnimationIsComplete):
(WebKit::PageClientImplCocoa::addTextAnimationForAnimationID):
(WebKit::PageClientImplCocoa::removeTextAnimationForAnimationID):
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::didEndPartialIntelligenceTextPonderingAnimationImpl):
(WebKit::WebPageProxy::didEndPartialIntelligenceTextPonderingAnimation):
(WebKit::WebPageProxy::showSelectionForActiveWritingToolsSessionIfNeeded):
(WebKit::WebPageProxy::showSelectionForActiveWritingToolsSession): Deleted.
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView replacementEffectDidComplete]):
* Source/WebKit/UIProcess/mac/WKTextAnimationManager.mm:
(-[WKTextAnimationManager addTextAnimationForAnimationID:withData:]):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::writingToolsCompositionSessionDidReceiveRestartAction): Deleted.
(WebKit::WebViewImpl::writingToolsCompositionSessionDidReceiveReplacements): Deleted.
(WebKit::WebViewImpl::isWritingToolsTextReplacementsFinished const): Deleted.
(WebKit::WebViewImpl::isIntelligenceTextPonderingAnimationFinished const): Deleted.
(WebKit::WebViewImpl::willBeginPartialIntelligenceTextPonderingAnimation): Deleted.
(WebKit::WebViewImpl::didEndPartialIntelligenceTextPonderingAnimation): Deleted.
* Source/WebKit/WebKitSwift/TextAnimation/TextAnimationManager.swift:
(TextAnimationManager.performReplacementAndGeneratePreview(for:effect:animation:)):
(TextAnimationManager.replacementEffectDidComplete(_:)):
* Source/WebKit/WebKitSwift/TextAnimation/WKSTextAnimationSourceDelegate.h:

Canonical link: https://commits.webkit.org/282570@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications