[webkit-changes] [WebKit/WebKit] 526cd9: Let websites override system-default accessibility...

[Dana Estra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 526cd9597fafe37c83d5aab52b46f7ddc1e5a8f4
      https://github.com/WebKit/WebKit/commit/526cd9597fafe37c83d5aab52b46f7ddc1e5a8f4
  Author: Dana Estra <destra at apple.com>
  Date:   2024-08-21 (Wed, 21 Aug 2024)

  Changed paths:
    M Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp
    M Source/WebCore/platform/cf/MediaAccessibilitySoftLink.cpp
    M Source/WebCore/platform/cf/MediaAccessibilitySoftLink.h

  Log Message:
  -----------
  Let websites override system-default accessibility caption styling
https://bugs.webkit.org/show_bug.cgi?id=278319
rdar://134265139

Reviewed by Eric Carlson.

In the system accessibility settings, users can select a system-default caption style,
or create a custom style, which changes how webvtt captions appear on websites.
Currently, the system’s default styles override websites’ styling, even though
often the user did not select this styling and is just using the default.

This patch makes it so that if the accessibility caption style is a system-default
style, it is overridable by the website.

* Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::behaviorShouldNotBeOverriden):
(WebCore::CaptionUserPreferencesMediaAF::captionsWindowCSS const):
(WebCore::CaptionUserPreferencesMediaAF::captionsBackgroundCSS const):
(WebCore::CaptionUserPreferencesMediaAF::captionsTextColor const):
(WebCore::CaptionUserPreferencesMediaAF::windowRoundedCornerRadiusCSS const):
(WebCore::CaptionUserPreferencesMediaAF::captionStrokeWidthForFont const):
(WebCore::CaptionUserPreferencesMediaAF::captionsTextEdgeCSS const):
(WebCore::CaptionUserPreferencesMediaAF::captionsDefaultFontCSS const):
(WebCore::CaptionUserPreferencesMediaAF::captionFontSizeScaleAndImportance const):
* Source/WebCore/platform/cf/MediaAccessibilitySoftLink.cpp:
* Source/WebCore/platform/cf/MediaAccessibilitySoftLink.h:

Canonical link: https://commits.webkit.org/282568@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications