[webkit-changes] [WebKit/WebKit] 8e565c: [JSC] wasm unaligned atomic accesses should trap w...

[Dan Hecht]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e565ca70a2499c689a50b5b81a8277585782561
      https://github.com/WebKit/WebKit/commit/8e565ca70a2499c689a50b5b81a8277585782561
  Author: Dan Hecht <dan.hecht at apple.com>
  Date:   2024-08-21 (Wed, 21 Aug 2024)

  Changed paths:
    A JSTests/wasm/stress/atomic-unaligned-traps.js
    M Source/JavaScriptCore/llint/InPlaceInterpreter64.asm
    M Source/JavaScriptCore/llint/WebAssembly32_64.asm
    M Source/JavaScriptCore/llint/WebAssembly64.asm
    M Source/JavaScriptCore/wasm/WasmBBQJIT32_64.cpp
    M Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp
    M Source/JavaScriptCore/wasm/WasmExceptionType.h
    M Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp

  Log Message:
  -----------
  [JSC] wasm unaligned atomic accesses should trap with "Unaligned" rather than "Out of bounds"
https://bugs.webkit.org/show_bug.cgi?id=278412
rdar://103442167

Reviewed by Yusuke Suzuki.

Introduce a new wasm trap for "Unaligned memory access" and use it
when atomic alignment is checked. Previously, unaligned atomic
accesses would produce an "Out of bounds memory access" trap.

* JSTests/wasm/stress/atomic-unaligned-traps.js: Added.
(genAtomicInstr):
(genWat):
(async test):
* Source/JavaScriptCore/llint/InPlaceInterpreter64.asm:
* Source/JavaScriptCore/llint/WebAssembly32_64.asm:
* Source/JavaScriptCore/llint/WebAssembly64.asm:
* Source/JavaScriptCore/wasm/WasmBBQJIT32_64.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::emitAtomicLoadOp):
(JSC::Wasm::BBQJITImpl::BBQJIT::emitAtomicStoreOp):
(JSC::Wasm::BBQJITImpl::BBQJIT::emitAtomicBinaryRMWOp):
(JSC::Wasm::BBQJITImpl::BBQJIT::emitAtomicCompareExchange):
* Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::emitAtomicLoadOp):
(JSC::Wasm::BBQJITImpl::BBQJIT::emitAtomicStoreOp):
(JSC::Wasm::BBQJITImpl::BBQJIT::emitAtomicBinaryRMWOp):
(JSC::Wasm::BBQJITImpl::BBQJIT::emitAtomicCompareExchange):
* Source/JavaScriptCore/wasm/WasmExceptionType.h:
(JSC::Wasm::isTypeErrorExceptionType):
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp:
(JSC::Wasm::OMGIRGenerator::fixupPointerPlusOffsetForAtomicOps):
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp:
(JSC::Wasm::OMGIRGenerator::fixupPointerPlusOffsetForAtomicOps):

Canonical link: https://commits.webkit.org/282561@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications