[webkit-changes] [WebKit/WebKit] 115794: [IFC][Invalidation] Layout level styleWillChange s...

Alan Baradlay noreply at github.com
Wed Aug 21 05:20:00 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 11579490c7d04e967bdc2f0120b6c702c25eb5f8
      https://github.com/WebKit/WebKit/commit/11579490c7d04e967bdc2f0120b6c702c25eb5f8
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-08-21 (Wed, 21 Aug 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp
    M Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
    M Source/WebCore/rendering/RenderButton.cpp
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/RenderMenuList.cpp

  Log Message:
  -----------
  [IFC][Invalidation] Layout level styleWillChange should disable partial layout
https://bugs.webkit.org/show_bug.cgi?id=278417

Reviewed by Antti Koivisto.

IFC does not yet support partial invalidation on layout type of style change. This patch ensures that whenever we see such change
the inline damage gets reset to "full layout".

* Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp:
(WebCore::Layout::InlineInvalidation::rootStyleWillChange):
(WebCore::Layout::InlineInvalidation::styleWillChange):
(WebCore::Layout::InlineInvalidation::setFullLayoutIfNeeded):
* Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.h:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::styleWillChange):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h:
* Source/WebCore/rendering/RenderButton.cpp:
(WebCore::RenderButton::setInnerRenderer):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::styleWillChange):
* Source/WebCore/rendering/RenderMenuList.cpp:
(WebCore::if):

Canonical link: https://commits.webkit.org/282557@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list