[webkit-changes] [WebKit/WebKit] 211071: Unreviewed, suppress wrong threading assertion for...

Yusuke Suzuki noreply at github.com
Tue Aug 20 18:11:23 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 211071789f3bfeb4c01ff71c329637e87755b0b0
      https://github.com/WebKit/WebKit/commit/211071789f3bfeb4c01ff71c329637e87755b0b0
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-08-20 (Tue, 20 Aug 2024)

  Changed paths:
    M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
    M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h

  Log Message:
  -----------
  Unreviewed, suppress wrong threading assertion for InlineCacheHandler
https://bugs.webkit.org/show_bug.cgi?id=278435
rdar://134290611

It gets destroyed in the GC end phase and it gets stale assertion about threading checks. But that assertion is wrong since
GC end phase is ensuring that we are not running mutator, so we can safely and correctly derefing this InlineCacheHandler inside it.
This is fixing this wrong assertion.

* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::m_watchpoint):
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.h:

Canonical link: https://commits.webkit.org/282538@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list