[webkit-changes] [WebKit/WebKit] 3581a1: Update click/auxclick/contextmenu and click() to u...

Richard Robinson noreply at github.com
Tue Aug 20 15:42:34 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3581a1e578bbe034efda7d6030d7bc528af6db8a
      https://github.com/WebKit/WebKit/commit/3581a1e578bbe034efda7d6030d7bc528af6db8a
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-08-20 (Tue, 20 Aug 2024)

  Changed paths:
    M LayoutTests/accessibility/links-activation-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_auxclick_is_a_pointerevent_mouse-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_click_is_a_pointerevent_mouse-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_click_is_a_pointerevent_multiple_clicks_mouse-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_click_is_a_pointerevent_multiple_clicks_pen-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_contextmenu_is_a_pointerevent_mouse-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/uievents/interface/click-event-expected.txt
    M LayoutTests/platform/mac/TestExpectations
    M LayoutTests/platform/mac/fast/events/objc-event-api-expected.txt
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/EventDispatcher.cpp
    M Source/WebCore/dom/MouseRelatedEvent.cpp
    M Source/WebCore/dom/MouseRelatedEvent.h
    M Source/WebCore/dom/PointerEvent.cpp
    M Source/WebCore/dom/PointerEvent.h
    M Source/WebCore/dom/SimulatedClick.cpp
    M Source/WebCore/page/PointerCaptureController.cpp
    M Source/WebKit/Shared/WebMouseEvent.cpp

  Log Message:
  -----------
  Update click/auxclick/contextmenu and click() to use PointerEvent
https://bugs.webkit.org/show_bug.cgi?id=218665
rdar://71202646

Reviewed by Abrar Rahman Protyasha.

Change the `click`, `auxclick`, and `contextmenu` events to be `PointerEvent`s instead of only
`MouseEvent`s.

Additionally, make the `click()` function dispatch a `PointerEvent` instead of a `MouseEvent`.

* LayoutTests/accessibility/links-activation-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-pointerevent_touch-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_auxclick_is_a_pointerevent_mouse-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_click_is_a_pointerevent_mouse-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_click_is_a_pointerevent_multiple_clicks_mouse-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_click_is_a_pointerevent_multiple_clicks_pen-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_contextmenu_is_a_pointerevent_mouse-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/uievents/interface/click-event-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt:
* LayoutTests/platform/mac/TestExpectations:
* LayoutTests/platform/mac/fast/events/objc-event-api-expected.txt:
* Source/WebCore/dom/Element.cpp:
(WebCore::dispatchPointerEventIfNeeded):
(WebCore::Element::dispatchMouseEvent):
* Source/WebCore/dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
* Source/WebCore/dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
* Source/WebCore/dom/MouseRelatedEvent.h:
(WebCore::MouseRelatedEvent::windowLocation const):
* Source/WebCore/dom/PointerEvent.cpp:
(WebCore::PointerEvent::typeFromMouseEventType):
(WebCore::PointerEvent::create):
(WebCore::PointerEvent::PointerEvent):
(WebCore::pointerEventType): Deleted.
* Source/WebCore/dom/PointerEvent.h:
(WebCore::PointerEvent::buttonForType):
(WebCore::PointerEvent::typeRequiresResolvedButton):
(WebCore::PointerEvent::typeIsUpOrDown): Deleted.
* Source/WebCore/dom/SimulatedClick.cpp:
(WebCore::simulatePointerEvent):
(WebCore::simulateClick):
* Source/WebCore/page/PointerCaptureController.cpp:
(WebCore::PointerCaptureController::pointerEventForMouseEvent):
(WebCore::pointerEventType): Deleted.
* Source/WebKit/Shared/WebMouseEvent.cpp:
(WebKit::mouseButton):

Canonical link: https://commits.webkit.org/282524@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list