[webkit-changes] [WebKit/WebKit] 2f1c29: [WebAuthn] Fix ordering of buildClientDataJson to ...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f1c292213b9af0645f56fb62e6b4f7cf83cc927
      https://github.com/WebKit/WebKit/commit/2f1c292213b9af0645f56fb62e6b4f7cf83cc927
  Author: Pascoe <pascoe at apple.com>
  Date:   2024-08-20 (Tue, 20 Aug 2024)

  Changed paths:
    M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm

  Log Message:
  -----------
  [WebAuthn] Fix ordering of buildClientDataJson to match limited verification algorithm
rdar://134290905
https://bugs.webkit.org/show_bug.cgi?id=278347

Reviewed by Charlie Wolfe.

Some parties that verify clientDataJSON may not want a full JSON parser. Therefore
Web Authentication has decided to restrict the construction of ClientDataJSON and
define an order for the elements such that it can parsed with simple steps.

This change puts our code that builds clientDataJSON in line with the spec for the
limited clientDataJSON by adjusting the order.

* Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp:
(WebCore::buildClientDataJson):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST(WebAuthenticationPanel, EncodeClientDataJSONWithTopOrigin)):
Added API test to confirm behavior.

Canonical link: https://commits.webkit.org/282512@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications