[webkit-changes] [WebKit/WebKit] 7a9185: Fix handling of non-renderable inner rounded corners

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a91855053563bd0ae3951d760df6325368e0bad
      https://github.com/WebKit/WebKit/commit/7a91855053563bd0ae3951d760df6325368e0bad
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-08-20 (Tue, 20 Aug 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/RoundedRect.cpp
    M Source/WebCore/rendering/BackgroundPainter.cpp
    M Source/WebCore/rendering/BackgroundPainter.h
    M Source/WebCore/rendering/RenderReplaced.cpp
    M Source/WebCore/rendering/RenderWidget.cpp

  Log Message:
  -----------
  Fix handling of non-renderable inner rounded corners
https://bugs.webkit.org/show_bug.cgi?id=278348
rdar://134291462

Reviewed by Alan Baradlay.

117367 at main added some code for non-renderable inner borders, but this is really a bug in RoundedRect::adjustRadii(),
which used `int` for `maxRadiusWidth` and `maxRadiusHeight` which caused the adjustment to fail to make the rect
renderable for some rects (tested by fast/css/background-clip-radius-values.html).

After fixing that, I could not find any layout tests that entered `BackgroundPainter::clipRoundedInnerRect()`
with a non-renderable rect, but add a clause to fix up the rect if necessary.

* Source/WebCore/rendering/BackgroundPainter.cpp:
(WebCore::BackgroundPainter::paintFillLayer const):
(WebCore::BackgroundPainter::clipRoundedInnerRect):
* Source/WebCore/rendering/BackgroundPainter.h:
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* Source/WebCore/rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):

Canonical link: https://commits.webkit.org/282503@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications