[webkit-changes] [WebKit/WebKit] 77eec0: [Writing Tools] Hide blinking insertion cursor whi...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77eec0a20396c7532b1f63a835b078e57747504c
      https://github.com/WebKit/WebKit/commit/77eec0a20396c7532b1f63a835b078e57747504c
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-08-20 (Tue, 20 Aug 2024)

  Changed paths:
    M Source/WebCore/PAL/pal/spi/mac/NSTextInputContextSPI.h
    M Source/WebCore/editing/Editor.cpp
    M Source/WebCore/editing/FrameSelection.cpp
    M Source/WebCore/editing/FrameSelection.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl
    M Source/WebKit/UIProcess/Cocoa/WKTextSelectionRect.h
    M Source/WebKit/UIProcess/Cocoa/WKTextSelectionRect.mm
    M Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/TextPlaceholderTests.mm

  Log Message:
  -----------
  [Writing Tools] Hide blinking insertion cursor while text placeholders are present
https://bugs.webkit.org/show_bug.cgi?id=278067
rdar://132432864

Reviewed by Aditya Keerthi.

Hide the caret when inserting the placeholder, and unhide it when removing the placeholder.

Also remove some staging declarations.

* Source/WebCore/PAL/pal/spi/mac/NSTextInputContextSPI.h:
* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::insertTextPlaceholder):
(WebCore::Editor::removeTextPlaceholder):
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::addCaretVisibilitySuppressionReason):
(WebCore::FrameSelection::removeCaretVisibilitySuppressionReason):
(WebCore::FrameSelection::updateCaretVisibility):
(WebCore::FrameSelection::setCaretVisibility): Deleted.
* Source/WebCore/editing/FrameSelection.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::isCaretVisible):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/UIProcess/Cocoa/WKTextSelectionRect.h:
* Source/WebKit/UIProcess/Cocoa/WKTextSelectionRect.mm:
* Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/TextPlaceholderTests.mm:
(createWebViewForNSTextPlaceholder):
(TEST(NSTextPlaceholder, InsertTextPlaceholder)):
(TEST(NSTextPlaceholder, InsertAndRemoveTextPlaceholderWithoutIncomingText)):
(TEST(NSTextPlaceholder, InsertAndRemoveTextPlaceholderWithIncomingText)):

Canonical link: https://commits.webkit.org/282500@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications