[webkit-changes] [WebKit/WebKit] 1efcb4: [Skia] Fix image filtering not being applied

[Patrick]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1efcb4f3b8fb9cc4d8a0b9084876415da46516ac
      https://github.com/WebKit/WebKit/commit/1efcb4f3b8fb9cc4d8a0b9084876415da46516ac
  Author: Patrick Griffis <pgriffis at igalia.com>
  Date:   2024-08-20 (Tue, 20 Aug 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/ImagePaintingOptions.h
    M Source/WebCore/platform/graphics/ImageTypes.h
    M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
    M Source/WebCore/rendering/RenderImage.cpp

  Log Message:
  -----------
  [Skia] Fix image filtering not being applied
https://bugs.webkit.org/show_bug.cgi?id=274827

Reviewed by Carlos Garcia Campos.

Per the docs you need the fast constraint for filtering to be applied:

   SrcRectConstraint controls the behavior at the edge of source SkRect,
   provided to drawImageRect() when there is any filtering. If kStrict is set,
   then extra code is used to ensure it never samples outside of the src-rect.
   kStrict_SrcRectConstraint disables the use of mipmaps and anisotropic filtering.

This change is only applied to rendering of images.

* Source/WebCore/platform/graphics/ImagePaintingOptions.h:
(WebCore::ImagePaintingOptions::strictImageClamping const):
(WebCore::ImagePaintingOptions::setOption):
* Source/WebCore/platform/graphics/ImageTypes.h:
* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContextSkia::drawNativeImageInternal):
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
* Source/WebCore/rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paintIntoRect):

Canonical link: https://commits.webkit.org/282492@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications