[webkit-changes] [WebKit/WebKit] 655f12: WorkerSWClientConnection should not invoke callbac...

Sihui noreply at github.com
Mon Aug 19 13:26:30 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 655f127964b691bd053177a07304d37a31b31c5d
      https://github.com/WebKit/WebKit/commit/655f127964b691bd053177a07304d37a31b31c5d
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-08-19 (Mon, 19 Aug 2024)

  Changed paths:
    M Source/WebCore/workers/service/ServiceWorkerRegistration.cpp
    M Source/WebCore/workers/service/WorkerSWClientConnection.cpp

  Log Message:
  -----------
  WorkerSWClientConnection should not invoke callback when it does not exist
https://bugs.webkit.org/show_bug.cgi?id=278334
rdar://134278561

Reviewed by Chris Dumez.

This patch also contains a drive-by fix for ServiceWorkerRegistration to reject Promise early when script execution
context has stopped.

* Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::addCookieChangeSubscriptions):
(WebCore::ServiceWorkerRegistration::removeCookieChangeSubscriptions):
(WebCore::ServiceWorkerRegistration::cookieChangeSubscriptions):
* Source/WebCore/workers/service/WorkerSWClientConnection.cpp:
(WebCore::WorkerSWClientConnection::addCookieChangeSubscriptions):
(WebCore::WorkerSWClientConnection::removeCookieChangeSubscriptions):
(WebCore::WorkerSWClientConnection::cookieChangeSubscriptions):

Canonical link: https://commits.webkit.org/282456@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list