[webkit-changes] [WebKit/WebKit] 450597: AX: VO announces value when ElementInternals.ariaV...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 450597ff73ce36b93e89439accf0f8055ad62fa9
      https://github.com/WebKit/WebKit/commit/450597ff73ce36b93e89439accf0f8055ad62fa9
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-08-19 (Mon, 19 Aug 2024)

  Changed paths:
    A LayoutTests/accessibility/indeterminate-progressbar-custom-element-expected.txt
    A LayoutTests/accessibility/indeterminate-progressbar-custom-element.html
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/accessibility/AccessibilityObject.cpp

  Log Message:
  -----------
  AX: VO announces value when ElementInternals.ariaValueNow is set to null
https://bugs.webkit.org/show_bug.cgi?id=275107
rdar://129218234

Reviewed by Chris Fleizach.

This bug happened because prior to this commit, `AccessibilityObject::hasAttribute` returned true
even if an ElementInternals attribute had been set to null (which should be treated the same as removing
the attribute), because that's how `CustomElementDefaultARIA::hasAttribute` behaves. This influences
various functions, such as `AccessibilityNodeObject::isIndeterminate()`.

Fix this by checking that `CustomElementDefaultARIA::valueForAttribute` is not null, which is a more
accurate representation of whether the element "has" the attribute.

* LayoutTests/accessibility/indeterminate-progressbar-custom-element-expected.txt: Added.
* LayoutTests/accessibility/indeterminate-progressbar-custom-element.html: Added.
* LayoutTests/platform/ios/TestExpectations: Enable new test.
* LayoutTests/platform/mac-wk1/TestExpectations: Skip new test.
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasAttribute const):

Canonical link: https://commits.webkit.org/282422@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications