[webkit-changes] [WebKit/WebKit] 913896: AX: Support display:contents for tbody elements

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9138960e6c997b65b73ab22dd7151217b04b9345
      https://github.com/WebKit/WebKit/commit/9138960e6c997b65b73ab22dd7151217b04b9345
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-08-18 (Sun, 18 Aug 2024)

  Changed paths:
    A LayoutTests/accessibility/display-contents/table-section-elements-expected.txt
    A LayoutTests/accessibility/display-contents/table-section-elements.html
    A LayoutTests/platform/glib/accessibility/display-contents/table-section-elements-expected.txt
    M LayoutTests/platform/ios/TestExpectations
    A LayoutTests/platform/ios/accessibility/display-contents/table-section-elements-expected.txt
    M Source/WebCore/accessibility/AccessibilityObject.cpp

  Log Message:
  -----------
  AX: Support display:contents for tbody elements
https://bugs.webkit.org/show_bug.cgi?id=275029
rdar://129131780

Reviewed by Chris Fleizach.

To avoid double-inserting the children of display:contents elements, we have a check in `AccessibilityObject::insertChild`
that exits early if the child we're inserting has a display:contents parent that is not `this` in the context of that
function.

This works great under the assumption that something eventually calls `insertChild` on the `display:contents` element.
However, that never happens for table section elements when `AccessibilityTable::addChildren` runs — it only calls
`insertChild` (indirectly, through `addChild`) on the actual table rows.

This patch fixes the bug by adjusting the check in `AccessibilityObject::insertChild` to accomodate this scenario,
and adds a new testcase to prevent it from regressing.

* LayoutTests/accessibility/display-contents/table-section-elements-expected.txt: Added.
* LayoutTests/accessibility/display-contents/table-section-elements.html: Added.
* LayoutTests/platform/glib/accessibility/display-contents/table-section-elements-expected.txt: Added.
* LayoutTests/platform/ios/TestExpectations: Enable new test.
* LayoutTests/platform/ios/accessibility/display-contents/table-section-elements-expected.txt: Added.
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::insertChild):

Canonical link: https://commits.webkit.org/282413@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications