[webkit-changes] [WebKit/WebKit] 46ad92: Stop using a LegacyNullableObjectIdentifier for El...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46ad92f74292ea05158ea59c554642b739a2e8f2
      https://github.com/WebKit/WebKit/commit/46ad92f74292ea05158ea59c554642b739a2e8f2
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-08-18 (Sun, 18 Aug 2024)

  Changed paths:
    M Source/WTF/wtf/ObjectIdentifier.h
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/ElementContext.h
    M Source/WebCore/dom/ElementIdentifier.h
    M Source/WebCore/loader/DocumentLoader.cpp
    M Source/WebCore/page/ElementTargetingController.cpp
    M Source/WebCore/page/ElementTargetingController.h
    M Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.h
    M Source/WebCore/platform/ScrollSnapAnimatorState.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebKit/Shared/WTFArgumentCoders.serialization.in
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/UIProcess/API/Cocoa/_WKTextInputContext.mm
    M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
    M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
    M Source/WebKit/UIProcess/WebNavigationState.cpp
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  Stop using a LegacyNullableObjectIdentifier for ElementIdentifier
https://bugs.webkit.org/show_bug.cgi?id=278278

Reviewed by Brady Eidson.

Stop using a LegacyNullableObjectIdentifier for ElementIdentifier and
use an ObjectIdentifier instead.

* Source/WTF/wtf/ObjectIdentifier.h:
(WTF::ObjectIdentifierGenericBase<uint64_t>::toRawValue const):
(WTF::ObjectIdentifierGenericBase<UUID>::toRawValue const):
(WTF::ObjectIdentifierGeneric::ObjectIdentifierGeneric):
(WTF::ObjectIdentifierGeneric::requires):
(WTF::ObjectIdentifierGeneric::MarkableTraits::isEmptyValue):
(WTF::ObjectIdentifierGenericBase<uint64_t>::operator bool const): Deleted.
(WTF::ObjectIdentifierGenericBase<UUID>::operator bool const): Deleted.
* Source/WebCore/dom/ElementIdentifier.h:
* Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick):
* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setNavigationID):
* Source/WebCore/page/ElementTargetingController.cpp:
(WebCore::ElementTargetingController::adjustVisibilityInRepeatedlyTargetedRegions):
(WebCore::ElementTargetingController::resetVisibilityAdjustments):
* Source/WebCore/page/ElementTargetingController.h:
* Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.h:
* Source/WebCore/platform/ScrollSnapAnimatorState.cpp:
(WebCore::ScrollSnapAnimatorState::preserveCurrentTargetForAxis):
(WebCore::ScrollSnapAnimatorState::currentlySnappedBoxes const):
(WebCore::chooseBoxToResnapTo):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::isElementAlive const):
* Source/WebKit/Shared/WTFArgumentCoders.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/API/Cocoa/_WKTextInputContext.mm:
(-[_WKTextInputContext boundingRect]):
(-[_WKTextInputContext _textInputContext]):
(-[_WKTextInputContext isEqual:]):
(-[_WKTextInputContext hash]):
* Source/WebKit/UIProcess/Cocoa/WKTextPlaceholder.mm:
(-[WKTextPlaceholder elementContext]):
(-[WKTextPlaceholder rects]):
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::triggerBrowsingContextGroupSwitchForNavigation):
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::validateInput):
* Source/WebKit/UIProcess/WebNavigationState.cpp:
(WebKit::WebNavigationState::navigation):
(WebKit::WebNavigationState::takeNavigation):
(WebKit::WebNavigationState::didDestroyNavigation):
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::documentLoaderDetached):

Canonical link: https://commits.webkit.org/282407@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications