[webkit-changes] [WebKit/WebKit] c213f1: Crash in TimerBase::~TimerBase via DataDetection::...

Ryosuke Niwa noreply at github.com
Fri Aug 16 18:56:59 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c213f1482344766a10d916bf190fdd2db73ebdaf
      https://github.com/WebKit/WebKit/commit/c213f1482344766a10d916bf190fdd2db73ebdaf
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-08-16 (Fri, 16 Aug 2024)

  Changed paths:
    M Source/WebCore/editing/cocoa/DataDetection.mm

  Log Message:
  -----------
  Crash in TimerBase::~TimerBase via DataDetection::detectContentInFrame
https://bugs.webkit.org/show_bug.cgi?id=278259
<rdar://133488287>

Reviewed by Wenson Hsieh.

Speculative fix. Use a WeakPtr instead of RefPtr in detectContentInFrame so that
we don't attempt to destruct Document in a background thread.

* Source/WebCore/editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::detectContentInFrame):

Canonical link: https://commits.webkit.org/282380@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list