[webkit-changes] [WebKit/WebKit] 8421fb: SimulateClickOverText.ClickTargets* API tests fail...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8421fbee7147dcdb93db4df38a273e55ca967eec
      https://github.com/WebKit/WebKit/commit/8421fbee7147dcdb93db4df38a273e55ca967eec
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-08-16 (Fri, 16 Aug 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  SimulateClickOverText.ClickTargets* API tests fail with debug assertions
https://bugs.webkit.org/show_bug.cgi?id=278255

Reviewed by Richard Robinson.

These API tests were hitting a debug assertion in `RenderObject::absoluteTextRects`, due to the fact
that both `UseVisibleBounds` and `IgnoreTinyRects` options were being ignored when calling into that
method.

Fix this by using `absoluteBorderAndTextRects` instead, which both honors the two options above when
computing the bounding rect, and fulfills the same purpose as `absoluteTextRects`.

* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::simulateClickOverFirstMatchingTextInViewportWithUserInteraction):

Canonical link: https://commits.webkit.org/282374@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications