[webkit-changes] [WebKit/WebKit] 3fc25c: Fix AllowTestOnlyIPC on the GTK port and clean up ...

Commit Queue noreply at github.com
Fri Aug 16 12:03:12 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3fc25c74fd8f239bf28a775a9af9a1154b76c182
      https://github.com/WebKit/WebKit/commit/3fc25c74fd8f239bf28a775a9af9a1154b76c182
  Author: Pascoe <pascoe at apple.com>
  Date:   2024-08-16 (Fri, 16 Aug 2024)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Tools/WebKitTestRunner/TestController.cpp
    M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm

  Log Message:
  -----------
  Fix AllowTestOnlyIPC on the GTK port and clean up other ports
rdar://133475043
https://bugs.webkit.org/show_bug.cgi?id=277813

Reviewed by Charlie Wolfe.

The cocoa and windows ports currently manually set this value when resetting
preferences, but because it's in platform code, it does not get set on the GTK
port. This causes tests that rely on AllowTestOnlyIPC to fail. This patch fixes
that by setting it when calling TestController's resetPreferencesToConsistentValues.

* LayoutTests/platform/glib/TestExpectations:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateWebView):

Canonical link: https://commits.webkit.org/282361@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list