[webkit-changes] [WebKit/WebKit] f77d40: Enable `::target-text` by default

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f77d4048340302fbea5f774abfed8dfa3b5ee7fb
      https://github.com/WebKit/WebKit/commit/f77d4048340302fbea5f774abfed8dfa3b5ee7fb
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2024-08-16 (Fri, 16 Aug 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  -----------
  Enable `::target-text` by default
https://bugs.webkit.org/show_bug.cgi?id=278210
rdar://134010063

Reviewed by Abrar Rahman Protyasha, Richard Robinson and Tim Nguyen.

Allow authors to style text fragments that have been scrolled to.

* LayoutTests/TestExpectations:

The remaining test failures are common to all highlight pseudo-elements, or
incorrect tests that require a re-sync.

target-text-004.html: currentColor on a highlight pseudo-element’s color
property should represent the color of the next active highlight pseudo-element
layer below. This is unimplemented for all the other highlight pseudos, which
are already enabled. See https://drafts.csswg.org/css-pseudo/#highlight-text.

target-text-005.html: Highlight pseudo-elements should have a relative,
overlayed, paint order. See https://drafts.csswg.org/css-pseudo/#highlight-backgrounds.

target-text-009.html: Non-inherited properties that apply to highlights should
be inherited when using highlight styles. For example, `p::selection`'s
background-color should apply to a `<span>` child of a `<p>`. Only Chrome
implements this behavior. See https://drafts.csswg.org/css-pseudo/#highlight-cascade.

target-text-dynamic-004.html: This test is incorrect. It attempts to assert a
style on a `<span>` element when the document doesn't contain any. This was fixed
upstream in `51725f0`. The corrected version of the test is passing, and will
be imported into the tree in https://webkit.org/b/277692.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

The feature remains disabled in WebKitLegacy, matching `ScrollToTextFragmentEnabled`.

Canonical link: https://commits.webkit.org/282356@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications