[webkit-changes] [WebKit/WebKit] f1b791: Commit message reviewer list should use oxford com...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1b791522de861c81203369526878b89c1057c4f
      https://github.com/WebKit/WebKit/commit/f1b791522de861c81203369526878b89c1057c4f
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-08-16 (Fri, 16 Aug 2024)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py
    M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/string_utils.py
    M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/string_utils_unittest.py
    M Tools/Scripts/webkitpy/tool/commands/download_unittest.py
    M Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py

  Log Message:
  -----------
  Commit message reviewer list should use oxford comma as needed
https://bugs.webkit.org/show_bug.cgi?id=278138
rdar://133897321

Reviewed by Wenson Hsieh, Tim Horton and Richard Robinson.

Currently, if your patch has 3 reviewers (A, B, C), the reviewer list in
the patch (post landing) will read "A, B and C". After this patch, it
will read "A, B, and C", instead.

To achieve this, we imbibe the concept of a serial/oxford comma in both
tooling codepaths that require us to join items with conjunctions, namely
the AddReviewerMixin in CISupport.ews-build, and the string_utils.join()
method.

Furthermore, we update script test expectations to reflect this new
joining behavior.

* Tools/CISupport/ews-build/steps.py:
(AddReviewerMixin.reviewers):
(ValidateCommitMessage):
* Tools/CISupport/ews-build/steps_unittest.py:
(mock_load_contributors):
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/string_utils.py:
(join):
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/string_utils_unittest.py:
(StringUtils.test_list):
(StringUtils.test_split):
* Tools/Scripts/webkitpy/tool/commands/download_unittest.py:
* Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:

Canonical link: https://commits.webkit.org/282350@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications