[webkit-changes] [WebKit/WebKit] 4216bb: [WebXR] Specify that enableFoveation argument is a...

Dan Glastonbury noreply at github.com
Thu Aug 15 17:55:17 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4216bb07b87d9dd30fb1e5d53be7d4addad28cdd
      https://github.com/WebKit/WebKit/commit/4216bb07b87d9dd30fb1e5d53be7d4addad28cdd
  Author: Dan Glastonbury <djg at apple.com>
  Date:   2024-08-15 (Thu, 15 Aug 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
    M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in
    M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h
    M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h
    M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp

  Log Message:
  -----------
  [WebXR] Specify that enableFoveation argument is a PlatformGLObject
https://bugs.webkit.org/show_bug.cgi?id=278153
rdar://133921297

Reviewed by Kimmo Kinnunen.

GraphicsContextGL::enableFoveation takes a renderbuffer as it's only
argument. This needs to be declared as PlatformGLObject for generate-gpup-webgl
to generate the look up of the actual object id for the Renderbuffer, otherwise
an invalid id is passed to OpenGL.

* Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::GraphicsContextGLCocoa::enableFoveation):
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h:
(enableFoveation):
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:
(WebKit::RemoteGraphicsContextGLProxy::enableFoveation):

Canonical link: https://commits.webkit.org/282324@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list