[webkit-changes] [WebKit/WebKit] 760c07: [JSC] Remove useWasmTypedFunctionReferences and us...

Thu Aug 15 12:16:13 PDT 2024

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 760c07823975ffd394576c368a7757728013489a
      https://github.com/WebKit/WebKit/commit/760c07823975ffd394576c368a7757728013489a
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-08-15 (Thu, 15 Aug 2024)

  Changed paths:
    M JSTests/wasm.yaml
    M JSTests/wasm/extended-const/extended-const.js
    R JSTests/wasm/extended-const/flag-turned-off.js
    M JSTests/wasm/function-references/block_signature.js
    M JSTests/wasm/function-references/br_on_null.js
    M JSTests/wasm/function-references/bug243265.js
    M JSTests/wasm/function-references/call_ref.js
    M JSTests/wasm/function-references/local_init.js
    M JSTests/wasm/function-references/ref_as_non_null.js
    M JSTests/wasm/function-references/ref_types.js
    M JSTests/wasm/function-references/table.js
    M JSTests/wasm/function-references/table_init.js
    M JSTests/wasm/gc/any.js
    M JSTests/wasm/gc/array_new_data.js
    M JSTests/wasm/gc/array_new_elem.js
    M JSTests/wasm/gc/array_new_fixed.js
    M JSTests/wasm/gc/array_new_fixed_long.js
    M JSTests/wasm/gc/arrays.js
    M JSTests/wasm/gc/block.js
    M JSTests/wasm/gc/br_on_cast.js
    M JSTests/wasm/gc/bug247874.js
    M JSTests/wasm/gc/bug250613.js
    M JSTests/wasm/gc/bug252299.js
    M JSTests/wasm/gc/bug252538.js
    M JSTests/wasm/gc/bug252719.js
    M JSTests/wasm/gc/bug254226.js
    M JSTests/wasm/gc/bug254412.js
    M JSTests/wasm/gc/bug254413.js
    M JSTests/wasm/gc/bug254414.js
    M JSTests/wasm/gc/bug258127.js
    M JSTests/wasm/gc/bug258128.js
    M JSTests/wasm/gc/bug258499.js
    M JSTests/wasm/gc/bug258795.js
    M JSTests/wasm/gc/bug258796.js
    M JSTests/wasm/gc/bug258801.js
    M JSTests/wasm/gc/bug258804.js
    M JSTests/wasm/gc/bug258805.js
    M JSTests/wasm/gc/bug260516.js
    M JSTests/wasm/gc/bug262862.js
    M JSTests/wasm/gc/bug262863.js
    M JSTests/wasm/gc/bug265721.js
    M JSTests/wasm/gc/bug265742.js
    M JSTests/wasm/gc/bug265927.js
    M JSTests/wasm/gc/bug266043.js
    M JSTests/wasm/gc/bug266056.js
    M JSTests/wasm/gc/bug266127.js
    M JSTests/wasm/gc/bug266167.js
    M JSTests/wasm/gc/bug266249.js
    M JSTests/wasm/gc/bug267381.js
    M JSTests/wasm/gc/bulk-array.js
    M JSTests/wasm/gc/call_indirect.js
    M JSTests/wasm/gc/call_ref.js
    M JSTests/wasm/gc/casts.js
    R JSTests/wasm/gc/const-exprs-flag-off.js
    M JSTests/wasm/gc/const-exprs.js
    M JSTests/wasm/gc/eq.js
    M JSTests/wasm/gc/exception.js
    M JSTests/wasm/gc/extern.js
    M JSTests/wasm/gc/i31.js
    M JSTests/wasm/gc/js-api.js
    M JSTests/wasm/gc/limits.js
    M JSTests/wasm/gc/linking.js
    M JSTests/wasm/gc/packed-arrays.js
    M JSTests/wasm/gc/rec.js
    M JSTests/wasm/gc/simd.js
    M JSTests/wasm/gc/structs.js
    M JSTests/wasm/gc/sub.js
    M JSTests/wasm/gc/subtyping.js
    M JSTests/wasm/gc/table_init.js
    M JSTests/wasm/js-api/type-reflection-concrete-types.js
    M JSTests/wasm/references/element_active_mod.js
    M JSTests/wasm/references/func_ref.js
    M JSTests/wasm/references/is_null.js
    M JSTests/wasm/references/table_misc.js
    M JSTests/wasm/references/validation.js
    M JSTests/wasm/stress/funcref-types.js
    M JSTests/wasm/v8/regress/regress-1364036.js
    M Source/JavaScriptCore/runtime/Options.cpp
    M Source/JavaScriptCore/runtime/OptionsList.h
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp
    M Source/JavaScriptCore/wasm/WasmConstExprGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmFormat.h
    M Source/JavaScriptCore/wasm/WasmFunctionParser.h
    M Source/JavaScriptCore/wasm/WasmOperations.cpp
    M Source/JavaScriptCore/wasm/WasmParser.h
    M Source/JavaScriptCore/wasm/WasmSectionParser.cpp
    M Source/JavaScriptCore/wasm/WasmTable.cpp
    M Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h
    M Source/JavaScriptCore/wasm/js/WasmToJS.cpp
    M Tools/Scripts/run-jsc-stress-tests

  Log Message:
  -----------
  [JSC] Remove useWasmTypedFunctionReferences and useWasmExtendedConstantExpressions
https://bugs.webkit.org/show_bug.cgi?id=278173
rdar://133960341

Reviewed by Yijia Huang.

Remove already shipped feature flags useWasmTypedFunctionReferences and useWasmExtendedConstantExpressions.
In particular, our code was messed up so much with useWasmTypedFunctionReferences flag on/off. Removing
this flag significantly simplifies our code base, easier to maintain.

* JSTests/wasm.yaml:
* JSTests/wasm/extended-const/extended-const.js:
* JSTests/wasm/extended-const/flag-turned-off.js: Removed.
* JSTests/wasm/function-references/block_signature.js:
* JSTests/wasm/function-references/br_on_null.js:
* JSTests/wasm/function-references/bug243265.js:
* JSTests/wasm/function-references/call_ref.js:
* JSTests/wasm/function-references/local_init.js:
* JSTests/wasm/function-references/ref_as_non_null.js:
* JSTests/wasm/function-references/ref_types.js:
* JSTests/wasm/function-references/table.js:
* JSTests/wasm/function-references/table_init.js:
* JSTests/wasm/gc/any.js:
* JSTests/wasm/gc/array_new_data.js:
* JSTests/wasm/gc/array_new_elem.js:
* JSTests/wasm/gc/array_new_fixed.js:
* JSTests/wasm/gc/array_new_fixed_long.js:
* JSTests/wasm/gc/arrays.js:
* JSTests/wasm/gc/block.js:
* JSTests/wasm/gc/br_on_cast.js:
* JSTests/wasm/gc/bug247874.js:
* JSTests/wasm/gc/bug250613.js:
* JSTests/wasm/gc/bug252299.js:
* JSTests/wasm/gc/bug252538.js:
* JSTests/wasm/gc/bug252719.js:
* JSTests/wasm/gc/bug254226.js:
* JSTests/wasm/gc/bug254412.js:
* JSTests/wasm/gc/bug254413.js:
* JSTests/wasm/gc/bug254414.js:
* JSTests/wasm/gc/bug258127.js:
* JSTests/wasm/gc/bug258128.js:
* JSTests/wasm/gc/bug258499.js:
* JSTests/wasm/gc/bug258795.js:
* JSTests/wasm/gc/bug258796.js:
* JSTests/wasm/gc/bug258801.js:
* JSTests/wasm/gc/bug258804.js:
* JSTests/wasm/gc/bug258805.js:
* JSTests/wasm/gc/bug260516.js:
* JSTests/wasm/gc/bug262862.js:
* JSTests/wasm/gc/bug262863.js:
* JSTests/wasm/gc/bug265721.js:
* JSTests/wasm/gc/bug265742.js:
* JSTests/wasm/gc/bug265927.js:
* JSTests/wasm/gc/bug266043.js:
* JSTests/wasm/gc/bug266056.js:
* JSTests/wasm/gc/bug266127.js:
* JSTests/wasm/gc/bug266167.js:
* JSTests/wasm/gc/bug266249.js:
* JSTests/wasm/gc/bug267381.js:
* JSTests/wasm/gc/bulk-array.js:
* JSTests/wasm/gc/call_indirect.js:
* JSTests/wasm/gc/call_ref.js:
* JSTests/wasm/gc/casts.js:
* JSTests/wasm/gc/const-exprs-flag-off.js: Removed.
* JSTests/wasm/gc/const-exprs.js:
* JSTests/wasm/gc/eq.js:
* JSTests/wasm/gc/exception.js:
* JSTests/wasm/gc/extern.js:
* JSTests/wasm/gc/i31.js:
* JSTests/wasm/gc/js-api.js:
* JSTests/wasm/gc/limits.js:
* JSTests/wasm/gc/linking.js:
* JSTests/wasm/gc/packed-arrays.js:
* JSTests/wasm/gc/rec.js:
* JSTests/wasm/gc/simd.js:
* JSTests/wasm/gc/structs.js:
* JSTests/wasm/gc/sub.js:
* JSTests/wasm/gc/subtyping.js:
* JSTests/wasm/gc/table_init.js:
* JSTests/wasm/js-api/type-reflection-concrete-types.js:
* JSTests/wasm/references/element_active_mod.js:
(refNullExternInElemsSection):
* JSTests/wasm/references/func_ref.js:
(assert.eq.instance.exports.fix):
(assert.throws.fun): Deleted.
(assert.throws): Deleted.
(string_appeared_here.End.End.Function.End.Code.End.WebAssembly.imp.ref): Deleted.
(string_appeared_here.End.End.Function.End.Code.End.WebAssembly): Deleted.
(GetLocal.0.I32Const.0.TableSet.0.End.End.WebAssembly.fun): Deleted.
(GetLocal.0.I32Const.0.TableSet.0.End.End.WebAssembly.assert.throws): Deleted.
(GetLocal.0.I32Const.0.TableSet.0.End.End.WebAssembly): Deleted.
(assert.throws.doTest): Deleted.
(let.importedFun.of): Deleted.
(makeFuncrefIdent.fun): Deleted.
(b.b.GetLocal.0.End.End.End.WebAssembly): Deleted.
(foo): Deleted.
* JSTests/wasm/references/is_null.js:
(checkRefNullWithI32ImmType):
* JSTests/wasm/references/table_misc.js:
(GetLocal.0.GetLocal.1.TableGrow.0.End.End.WebAssembly): Deleted.
* JSTests/wasm/references/validation.js:
(assert.throws.new.WebAssembly.Module.bin):
(assert.throws): Deleted.
* JSTests/wasm/stress/funcref-types.js:
* JSTests/wasm/v8/regress/regress-1364036.js:
* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::disableAllWasmOptions):
* Source/JavaScriptCore/runtime/OptionsList.h:
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::addRefFunc):
* Source/JavaScriptCore/wasm/WasmConstExprGenerator.cpp:
(JSC::Wasm::parseExtendedConstExpr):
(JSC::Wasm::evaluateExtendedConstExpr):
* Source/JavaScriptCore/wasm/WasmFormat.h:
(JSC::Wasm::isValueType):
(JSC::Wasm::isRefType):
(JSC::Wasm::isExternref):
(JSC::Wasm::isFuncref):
(JSC::Wasm::funcrefType):
(JSC::Wasm::externrefType):
(JSC::Wasm::isRefWithTypeIndex):
(JSC::Wasm::isTypeIndexHeapType):
(JSC::Wasm::isSubtype):
* Source/JavaScriptCore/wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser::pushLocalInitialized):
(JSC::Wasm::FunctionParser::resetLocalInitStackToHeight):
(JSC::Wasm::FunctionParser::typeToStringModuleRelative const):
(JSC::Wasm::FunctionParser<Context>::parse):
(JSC::Wasm::FunctionParser<Context>::checkLocalInitialized):
(JSC::Wasm::FunctionParser<Context>::parseExpression):
(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):
* Source/JavaScriptCore/wasm/WasmOperations.cpp:
(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):
(JSC::Wasm::JSC_DEFINE_NOEXCEPT_JIT_OPERATION):
* Source/JavaScriptCore/wasm/WasmParser.h:
(JSC::Wasm::ParserBase::parseBlockSignature):
(JSC::Wasm::ParserBase::parseHeapType):
(JSC::Wasm::ParserBase::parseValueType):
* Source/JavaScriptCore/wasm/WasmSectionParser.cpp:
(JSC::Wasm::SectionParser::parseTableHelper):
(JSC::Wasm::SectionParser::parseElement):
(JSC::Wasm::SectionParser::parseInitExpr):
* Source/JavaScriptCore/wasm/WasmTable.cpp:
(JSC::Wasm::FuncRefTable::FuncRefTable):
* Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h:
(JSC::defaultValueForReferenceType):
* Source/JavaScriptCore/wasm/js/WasmToJS.cpp:
(JSC::Wasm::wasmToJS):
* Tools/Scripts/run-jsc-stress-tests:

Canonical link: https://commits.webkit.org/282301@main

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications