[webkit-changes] [WebKit/WebKit] dc2829: Merge full-width/full-height Overlay Regions when ...

[Etienne Segonzac]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc2829c6d51b5fbad8876d98764cda8b9068dcae
      https://github.com/WebKit/WebKit/commit/dc2829c6d51b5fbad8876d98764cda8b9068dcae
  Author: Etienne Segonzac <sgz at apple.com>
  Date:   2024-08-15 (Thu, 15 Aug 2024)

  Changed paths:
    M LayoutTests/overlay-region/full-page-dynamic-expected.txt
    M LayoutTests/overlay-region/full-page-expected.txt
    M LayoutTests/overlay-region/full-page-overflow-expected.txt
    M LayoutTests/overlay-region/full-page-overflow-scrolling-expected.txt
    M LayoutTests/overlay-region/full-page-scrolling-expected.txt
    A LayoutTests/overlay-region/merging-expected.txt
    A LayoutTests/overlay-region/merging.html
    A LayoutTests/overlay-region/no-merging-expected.txt
    A LayoutTests/overlay-region/no-merging.html
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm

  Log Message:
  -----------
  Merge full-width/full-height Overlay Regions when they intersect
https://bugs.webkit.org/show_bug.cgi?id=278121
<rdar://132904789>

Reviewed by Mike Wyrzykowski.

When configuring a ScrollView with Overlay regions, keep full-width/
full-height rects in separate vectors so we can easily merge them before
adding them to the final set.

* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(configureScrollViewWithOverlayRegionsIDs):
For each axis, sort the rects then simply check for overlap with y/maxY
x/maxX since we know the rects have the same width/height.

* LayoutTests/overlay-region/merging-expected.txt:
* LayoutTests/overlay-region/merging.html: Added.
* LayoutTests/overlay-region/no-merging-expected.txt:
* LayoutTests/overlay-region/no-merging.html: Added.
Add new tests for different cases where we merge or skip merging.

* LayoutTests/overlay-region/full-page-dynamic-expected.txt:
* LayoutTests/overlay-region/full-page-expected.txt:
* LayoutTests/overlay-region/full-page-overflow-expected.txt:
* LayoutTests/overlay-region/full-page-overflow-scrolling-expected.txt:
* LayoutTests/overlay-region/full-page-scrolling-expected.txt:
Update test expectations with merges.

Canonical link: https://commits.webkit.org/282278@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications