[webkit-changes] [WebKit/WebKit] 63415d: [JSC] U+2212 MINUS SIGN should be rejected in ISO8...

SUZUKI Sosuke noreply at github.com
Wed Aug 14 18:49:23 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 63415d14935cfbfc7e77866707034882c7b9a162
      https://github.com/WebKit/WebKit/commit/63415d14935cfbfc7e77866707034882c7b9a162
  Author: Sosuke Suzuki <aosukeke at gmail.com>
  Date:   2024-08-14 (Wed, 14 Aug 2024)

  Changed paths:
    M JSTests/stress/temporal-duration.js
    M JSTests/stress/temporal-instant.js
    M JSTests/stress/temporal-plaindate.js
    M JSTests/stress/temporal-plaindatetime.js
    M JSTests/stress/temporal-plaintime.js
    M JSTests/stress/temporal-timezone.js
    M JSTests/test262/expectations.yaml
    M Source/JavaScriptCore/runtime/ISO8601.cpp

  Log Message:
  -----------
  [JSC] U+2212 MINUS SIGN should be rejected in ISO8601 strings
https://bugs.webkit.org/show_bug.cgi?id=278075

Reviewed by Ross Kirsling.

In the latest Temporal spec[1], the U+2212 MINUS SIGN cannot be used to represent negative numbers.
This is consistent with RFC3339[2] and RFC9557[3].

However, the current JSC allows the U+2212 MINUS SIGN within ISO8601 strings.

This patch changes to reject the U+2212 MINUS SIGN as the symbol for negative numbers in ISO8601
strings.

[1]: https://github.com/tc39/proposal-temporal/pull/2856
[2]: https://www.rfc-editor.org/rfc/rfc3339
[3]: https://www.rfc-editor.org/rfc/rfc9557

* JSTests/test262/expectations.yaml:
* JSTests/stress/temporal-duration.js:
(shouldThrow.Temporal.Duration.from):
* JSTests/stress/temporal-instant.js:
* JSTests/stress/temporal-plaindate.js:
* JSTests/stress/temporal-plaindatetime.js:
* JSTests/stress/temporal-plaintime.js:
* JSTests/stress/temporal-timezone.js:
* JSTests/test262/expectations.yaml:
* Source/JavaScriptCore/runtime/ISO8601.cpp:
(JSC::ISO8601::parseDuration):
(JSC::ISO8601::parseTimeZoneNumericUTCOffset):
(JSC::ISO8601::parseUTCOffsetInMinutes):
(JSC::ISO8601::canBeTimeZone):
(JSC::ISO8601::parseTimeZoneBracketedAnnotation):
(JSC::ISO8601::parseTimeZone):
(JSC::ISO8601::parseDate):

Canonical link: https://commits.webkit.org/282272@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list