[webkit-changes] [WebKit/WebKit] 4b6a66: [UnifiedPDF] Context clicking outside a document s...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b6a66bd7beb483a52a11c3dba2b0ae13da8bf12
      https://github.com/WebKit/WebKit/commit/4b6a66bd7beb483a52a11c3dba2b0ae13da8bf12
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-08-14 (Wed, 14 Aug 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] Context clicking outside a document should not clear the selection
https://bugs.webkit.org/show_bug.cgi?id=278136
rdar://128480285

Reviewed by Sammy Gill.

Previously, context menu events fired outside of the document bounds
would clear the current selection, which matched behavior in the Preview
app. However, it would be more aligned with web content had we done the
converse.

This patch addresses the design sentiment captured in the bug by only
tracking a new selection if the context menu event is fired from inside
the document bounds.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::handleMouseEvent):

Canonical link: https://commits.webkit.org/282268@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications