[webkit-changes] [WebKit/WebKit] f79866: REGRESSION (277282 at main): Uncommitted IME text fai...

Wenson Hsieh noreply at github.com
Wed Aug 14 16:42:05 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f79866536e1d6fae27939f19050c1a354fec70da
      https://github.com/WebKit/WebKit/commit/f79866536e1d6fae27939f19050c1a354fec70da
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-08-14 (Wed, 14 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  -----------
  REGRESSION (277282 at main): Uncommitted IME text fails to render on x86_64 Macs only
https://bugs.webkit.org/show_bug.cgi?id=278129
rdar://133304088

Reviewed by Tim Horton and Richard Robinson.

Make sure that the value of `result` is initialized to `NO` in `WebViewImpl::setMarkedText`, so that
we don't erroneously try to render inline predictions when using marked text for regular IME (i.e.
Chinese, Japanese input).

* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::setMarkedText):

Canonical link: https://commits.webkit.org/282265@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list