[webkit-changes] [WebKit/WebKit] 271e48: REGRESSION (282671 at main): [ macOS iOS wk2 ] http/t...

Alex Christensen noreply at github.com
Wed Aug 14 15:09:28 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 271e48d835ea9210dde60856f4b60e9353fab3e5
      https://github.com/WebKit/WebKit/commit/271e48d835ea9210dde60856f4b60e9353fab3e5
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-08-14 (Wed, 14 Aug 2024)

  Changed paths:
    M LayoutTests/http/tests/resourceLoadStatistics/prevalent-resource-unhandled-keydown.html
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  -----------
  REGRESSION (282671 at main): [ macOS iOS wk2 ] http/tests/resourceLoadStatistics/prevalent-resource-unhandled-keydown.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=278051
rdar://133791320

Reviewed by Charlie Wolfe.

The test needs to simulate a keyDown then have the function in setStatisticsHasHadUserInteraction called.  Since
I made statisticsProcessStatisticsAndDataRecords async, I introduced a race condition that can be solved by calling
it after eventSender.keyDown.  I verified I could hit the race condition before but not after this change.

* LayoutTests/http/tests/resourceLoadStatistics/prevalent-resource-unhandled-keydown.html:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/282261@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list