[webkit-changes] [WebKit/WebKit] 9d9281: Address additional API feedback for Web Extensions.

Timothy Hatcher noreply at github.com
Wed Aug 14 12:46:26 PDT 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9d9281b1550693b34eae187e13642ae1329016b1
      https://github.com/WebKit/WebKit/commit/9d9281b1550693b34eae187e13642ae1329016b1
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-08-14 (Wed, 14 Aug 2024)

  Changed paths:
    M Source/WebCore/en.lproj/Localizable.strings
    M Source/WebKit/Modules/OSX_Private.modulemap
    M Source/WebKit/Modules/iOS_Private.modulemap
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionAction.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionCommand.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionCommandPrivate.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionContext.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionContext.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionController.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionControllerConfigurationPrivate.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionControllerDelegate.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionMessagePort.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionMessagePort.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionPrivate.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionTab.h
    A Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionTabConfiguration.h
    A Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionTabConfiguration.mm
    A Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionTabConfigurationInternal.h
    R Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionTabCreationOptions.h
    R Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionTabCreationOptions.mm
    R Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionTabCreationOptionsInternal.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionWindow.h
    A Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionWindowConfiguration.h
    A Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionWindowConfiguration.mm
    A Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionWindowConfigurationInternal.h
    R Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionWindowCreationOptions.h
    R Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionWindowCreationOptions.mm
    R Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionWindowCreationOptionsInternal.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTab.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTabCreationOptions.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionWindowCreationOptions.h
    M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIExtensionCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWindowsCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionWindowCocoa.mm
    M Source/WebKit/UIProcess/Extensions/WebExtension.serialization.in
    M Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp
    M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
    M Source/WebKit/UIProcess/Extensions/WebExtensionTab.h
    M Source/WebKit/UIProcess/Extensions/WebExtensionWindow.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPICookies.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIExtension.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIRuntime.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWindows.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm
    M Tools/TestWebKitAPI/cocoa/TestWebExtensionsDelegate.h
    M Tools/TestWebKitAPI/cocoa/TestWebExtensionsDelegate.mm
    M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.h
    M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm

  Log Message:
  -----------
  Address additional API feedback for Web Extensions.
https://webkit.org/b/278040
rdar://problem/133783321

Reviewed by Jeff Miller.

Address various API review comments with tweaks to various property names, header docs, and some classes.

* Source/WebCore/en.lproj/Localizable.strings: Updated with update-webkit-localizable-strings.
* Source/WebKit/Modules/OSX_Private.modulemap:
* Source/WebKit/Modules/iOS_Private.modulemap:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.mm:
(-[WKWebExtension hasPersistentBackgroundContent]):
(-[WKWebExtension _hasServiceWorkerBackgroundContent]):
(-[WKWebExtension _hasModularBackgroundContent]):
(-[WKWebExtension backgroundContentIsPersistent]): Deleted.
(-[WKWebExtension _backgroundContentIsServiceWorker]): Deleted.
(-[WKWebExtension _backgroundContentUsesModules]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionAction.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionCommand.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionCommandPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionContext.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionContext.mm:
(-[WKWebExtensionContext hasRequestedOptionalAccessToAllHosts]):
(-[WKWebExtensionContext setHasRequestedOptionalAccessToAllHosts:]):
(-[WKWebExtensionContext hasAccessToPrivateData]):
(-[WKWebExtensionContext setHasAccessToPrivateData:]):
(toImpl):
(-[WKWebExtensionContext requestedOptionalAccessToAllHosts]): Deleted.
(-[WKWebExtensionContext setRequestedOptionalAccessToAllHosts:]): Deleted.
(-[WKWebExtensionContext hasAccessInPrivateBrowsing]): Deleted.
(-[WKWebExtensionContext setHasAccessInPrivateBrowsing:]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionController.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionControllerConfigurationPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionControllerDelegate.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionMessagePort.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionMessagePort.mm:
(-[WKWebExtensionMessagePort sendMessage:completionHandler:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionTab.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionTabConfiguration.h: Renamed from WKWebExtensionTabCreationOptions.h.
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionTabConfiguration.mm: Renamed from WKWebExtensionTabCreationOptions.mm.
(-[WKWebExtensionTabConfiguration _init]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionTabConfigurationInternal.h: Renamed from WKWebExtensionTabCreationOptionsInternal.h.
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionWindow.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionWindowConfiguration.h: Renamed from WKWebExtensionWindowCreationOptions.h.
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionWindowConfiguration.mm: Renamed from WKWebExtensionWindowCreationOptions.mm.
(-[WKWebExtensionWindowConfiguration _init]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionWindowConfigurationInternal.h: Renamed from WKWebExtensionWindowCreationOptionsInternal.h.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTab.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTabCreationOptions.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionWindowCreationOptions.h:
* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIExtensionCocoa.mm:
(WebKit::WebExtensionContext::extensionIsAllowedIncognitoAccess):
* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm:
(WebKit::WebExtensionContext::runtimeOpenOptionsPage):
(WebKit::WebExtensionContext::runtimeSendNativeMessage):
* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm:
(WebKit::WebExtensionContext::tabsCreate):
* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWindowsCocoa.mm:
(WebKit::WebExtensionContext::windowsCreate):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::populateBackgroundPropertiesIfNeeded):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::setHasAccessToPrivateData):
(WebKit::WebExtensionContext::canOpenNewWindow const):
(WebKit::WebExtensionContext::userGesturePerformed):
(WebKit::WebExtensionContext::websiteDataStore const):
(WebKit::WebExtensionContext::setHasAccessInPrivateBrowsing): Deleted.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm:
(WebKit::WebExtensionController::addUserContentController):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm:
(WebKit::WebExtensionTab::WebExtensionTab):
(WebKit::WebExtensionTab::parameters const):
(WebKit::WebExtensionTab::changedParameters const):
(WebKit::WebExtensionTab::matches const):
(WebKit::WebExtensionTab::extensionHasAccess const):
(WebKit::WebExtensionTab::setReaderModeShowing):
(WebKit::WebExtensionTab::isReaderModeShowing const):
(WebKit::WebExtensionTab::isPlayingAudio const):
(WebKit::WebExtensionTab::detectWebpageLocale):
(WebKit::WebExtensionTab::captureVisibleWebpage):
(WebKit::WebExtensionTab::duplicate):
(WebKit::WebExtensionTab::shouldGrantPermissionsOnUserGesture const):
(WebKit::WebExtensionTab::isAudible const): Deleted.
(WebKit::WebExtensionTab::shouldGrantTabPermissionsOnUserGesture const): Deleted.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionWindowCocoa.mm:
(WebKit::WebExtensionWindow::WebExtensionWindow):
(WebKit::WebExtensionWindow::extensionHasAccess const):
(WebKit::WebExtensionWindow::isPrivate const):
* Source/WebKit/UIProcess/Extensions/WebExtension.serialization.in:
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp:
(WebKit::WebExtensionContext::userContentControllers const):
(WebKit::WebExtensionContext::pageListensForEvent const):
(WebKit::WebExtensionContext::processes const):
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
(WebKit::WebExtensionContext::hasAccessToPrivateData const):
(WebKit::WebExtensionContext::hasAccessInPrivateBrowsing const): Deleted.
* Source/WebKit/UIProcess/Extensions/WebExtensionTab.h:
(WebKit::WebExtensionTab::allChangedProperties):
* Source/WebKit/UIProcess/Extensions/WebExtensionWindow.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm:
(TestWebKitAPI::TEST(WKWebExtension, BackgroundParsing)):
(TestWebKitAPI::TEST(WKWebExtension, BackgroundPreferredEnvironmentParsing)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIAction, NavigationOpensInNewTab)):
(TestWebKitAPI::TEST(WKWebExtensionAPIAction, WindowOpenOpensInNewWindow)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPICookies.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPICookies, GetAllCookieStoresWithPrivateAccess)):
(TestWebKitAPI::TEST(WKWebExtensionAPICookies, GetAllIncognitoWithPrivateAccess)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, BlockedLoadInPrivateBrowsingTest)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIExtension.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIExtension, InIncognitoContext)):
(TestWebKitAPI::TEST(WKWebExtensionAPIExtension, IsAllowedIncognitoAccess)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIRuntime.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime, ConnectNative)):
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime, ConnectNativeWithInvalidMessage)):
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime, ConnectNativeWithUndefinedMessage)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, Create)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, CreateWithSpecifiedOptions)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, CreateWithRelativeURL)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, Duplicate)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, DuplicateWithOptions)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, QueryWithPrivateAccess)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, UpdatedEventWithPrivateAccess)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWindows.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIWindows, GetAll)):
(TestWebKitAPI::TEST(WKWebExtensionAPIWindows, GetAllWithPrivateAccess)):
(TestWebKitAPI::TEST(WKWebExtensionAPIWindows, Create)):
(TestWebKitAPI::TEST(WKWebExtensionAPIWindows, CreateWithRelativeURL)):
(TestWebKitAPI::TEST(WKWebExtensionAPIWindows, CreateWithRelativeURLs)):
(TestWebKitAPI::TEST(WKWebExtensionAPIWindows, CreateIncognitoWithoutPrivateAccess)):
(TestWebKitAPI::TEST(WKWebExtensionAPIWindows, CreateIncognitoWithPrivateAccess)):
* Tools/TestWebKitAPI/cocoa/TestWebExtensionsDelegate.h:
* Tools/TestWebKitAPI/cocoa/TestWebExtensionsDelegate.mm:
(-[TestWebExtensionsDelegate webExtensionController:openNewWindowUsingConfiguration:forExtensionContext:completionHandler:]):
(-[TestWebExtensionsDelegate webExtensionController:openNewTabUsingConfiguration:forExtensionContext:completionHandler:]):
(-[TestWebExtensionsDelegate webExtensionController:sendMessage:toApplicationWithIdentifier:forExtensionContext:replyHandler:]):
(-[TestWebExtensionsDelegate webExtensionController:openNewWindowWithOptions:forExtensionContext:completionHandler:]): Deleted.
(-[TestWebExtensionsDelegate webExtensionController:openNewTabWithOptions:forExtensionContext:completionHandler:]): Deleted.
(-[TestWebExtensionsDelegate webExtensionController:sendMessage:toApplicationIdentifier:forExtensionContext:replyHandler:]): Deleted.
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.h:
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm:
(-[TestWebExtensionManager initForExtension:extensionControllerConfiguration:]):
(-[TestWebExtensionTab isReaderModeActiveForWebExtensionContext:]):
(-[TestWebExtensionTab setReaderModeActive:forWebExtensionContext:completionHandler:]):
(-[TestWebExtensionTab duplicateForWebExtensionContext:withOptions:completionHandler:]):
(-[TestWebExtensionWindow openNewTabAtIndex:]):
(-[TestWebExtensionWindow isPrivateForWebExtensionContext:]):
(-[TestWebExtensionTab isReaderModeShowingForWebExtensionContext:]): Deleted.
(-[TestWebExtensionTab setReaderModeShowing:forWebExtensionContext:completionHandler:]): Deleted.
(-[TestWebExtensionWindow isUsingPrivateBrowsingForWebExtensionContext:]): Deleted.

Canonical link: https://commits.webkit.org/282252@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list