[webkit-changes] [WebKit/WebKit] 9f884c: [cocoa] Delete errorRecoveryMethod from failed pro...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9f884c5b6d055b75ccfe9514e20de4b055515cd3
      https://github.com/WebKit/WebKit/commit/9f884c5b6d055b75ccfe9514e20de4b055515cd3
  Author: Matthew Finkel <m_finkel at apple.com>
  Date:   2024-08-14 (Wed, 14 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/NavigationState.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm

  Log Message:
  -----------
  [cocoa] Delete errorRecoveryMethod from failed provisional navigation NSError
https://bugs.webkit.org/show_bug.cgi?id=277888
rdar://133571945

Reviewed by Chris Dumez.

I introduced this hack to plumb the information using the NSError's userInfo
dictionary, but this isn't needed anymore, so let's remove it.

* Source/WebKit/UIProcess/Cocoa/NavigationState.mm:
(WebKit::createErrorWithRecoveryAttempter):
(WebKit::NavigationState::NavigationClient::didFailProvisionalNavigationWithError):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(TEST(WKNavigation, HTTPSOnlyHTTPFallbackGoBack)):
(TEST(WKNavigation, HTTPSOnlyHTTPFallbackContinue)):
(TEST(WKNavigation, HTTPSOnlyHTTPFallbackBypassEnabledCertificateError)):
(TEST(WKNavigation, HTTPSOnlyWithSameSiteBypass)):
(TEST(WKNavigation, HTTPSOnlyWithHTTPRedirect)):

Canonical link: https://commits.webkit.org/282248@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications