[webkit-changes] [WebKit/WebKit] a27fb4: [WebKitLegacy] Fix -Wenum-compare in WebDefaultPol...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a27fb4bae52ef8b9ab9339790660631f387df44f
      https://github.com/WebKit/WebKit/commit/a27fb4bae52ef8b9ab9339790660631f387df44f
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-08-14 (Wed, 14 Aug 2024)

  Changed paths:
    M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj
    R Source/WebKitLegacy/mac/DefaultDelegates/WebDefaultPolicyDelegate.m
    A Source/WebKitLegacy/mac/DefaultDelegates/WebDefaultPolicyDelegate.mm
    M Tools/DumpRenderTree/DefaultPolicyDelegate.mm

  Log Message:
  -----------
  [WebKitLegacy] Fix -Wenum-compare in WebDefaultPolicyDelegate.m
<https://bugs.webkit.org/show_bug.cgi?id=278073>
<rdar://133809285>

Reviewed by Alex Christensen.

Use WTF::enumToUnderlyingType() to compare
WebNavigationTypePlugInRequest to a WebNavigationType enum.

Also convert WebDefaultPolicyDelegate.m to Obj-C++ source file so that
WTF::enumToUnderlyingType() can be used.

* Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:
- Rename WebDefaultPolicyDelegate.m to WebDefaultPolicyDelegate.mm.
* Source/WebKitLegacy/mac/DefaultDelegates/WebDefaultPolicyDelegate.mm: Rename from Source/WebKitLegacy/mac/DefaultDelegates/WebDefaultPolicyDelegate.m.
(-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
- Use WTF::enumToUnderlyingType() to fix the warning.
* Tools/DumpRenderTree/DefaultPolicyDelegate.mm:
(-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
- Use WTF::enumToUnderlyingType() instead of static_cast<unsigned>()
  to match code in WebDefaultPolicyDelegate.mm.

Canonical link: https://commits.webkit.org/282241@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications