[webkit-changes] [WebKit/WebKit] fc56b1: [WPE][Skia] Address pending review comments of 282...

[Miguel Gómez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc56b1c7abd33011e43565ab665053a52d8873f0
      https://github.com/WebKit/WebKit/commit/fc56b1c7abd33011e43565ab665053a52d8873f0
  Author: Miguel Gomez <magomez at igalia.com>
  Date:   2024-08-14 (Wed, 14 Aug 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/PlatformDisplay.h
    M Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp

  Log Message:
  -----------
  [WPE][Skia] Address pending review comments of 282223 at main
https://bugs.webkit.org/show_bug.cgi?id=278094

Reviewed by Carlos Garcia Campos and Nikolas Zimmermann.

Rename the env var with the MSAA samples, and don't try to create the test
SkSurface if the env var samples are 0 or 1, as that means disabling MSAA.
Move the call to initializeMSAASampleCount() to a place were we're sure that
there's a valid Skia context, and add make const the functions that return
the sample count.

* Source/WebCore/platform/graphics/PlatformDisplay.h:
* Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp:
(WebCore::initializeMSAASampleCount):
(WebCore::SkiaGLContext::sampleCount const):
(WebCore::SkiaGLContext::SkiaGLContext):
(WebCore::PlatformDisplay::msaaSampleCount const):
(WebCore::SkiaGLContext::sampleCount): Deleted.
(WebCore::PlatformDisplay::msaaSampleCount): Deleted.

Canonical link: https://commits.webkit.org/282233@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications