[webkit-changes] [WebKit/WebKit] 1bd3d2: [WPE][Skia] Enable MSAA when available

[Miguel Gómez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1bd3d2f0f7e6380b6d9e2e6003dfb2636b51b266
      https://github.com/WebKit/WebKit/commit/1bd3d2f0f7e6380b6d9e2e6003dfb2636b51b266
  Author: Miguel Gomez <magomez at igalia.com>
  Date:   2024-08-14 (Wed, 14 Aug 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/PlatformDisplay.h
    M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp
    M Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp
    M Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp

  Log Message:
  -----------
  [WPE][Skia] Enable MSAA when available
https://bugs.webkit.org/show_bug.cgi?id=277800

Reviewed by Carlos Garcia Campos.

Enable MSAA on WPE whenever possible. On x86 or x86_64, use eight samples
to get an antialiasing result similar to non MSAA. On embedded devices, use
four samples instead, as this is a nice compromise between quality and
resource usage. On GTK keep it disabled by default. The user can overwrite
this default value through the WEBKIT_MSAA_SAMPLE_COUNT env var.

Even if MSAA is reported as available by GLES, Skia has a lot of internal checks
that may disable it, so the best way to check whether we can use it with Skia is
trying to create a texture backed SkSurface with a sample count of four and
check whether it works.

* Source/WebCore/platform/graphics/PlatformDisplay.h:
* Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp:
(WebCore::ImageBufferSkiaAcceleratedBackend::create):
(WebCore::flushSurfaceIfNeeded):
(WebCore::ImageBufferSkiaAcceleratedBackend::copyNativeImage):
(WebCore::ImageBufferSkiaAcceleratedBackend::createNativeImageReference):
* Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp:
(WebCore::initializeMSAASampleCount):
(WebCore::SkiaGLContext::sampleCount):
(WebCore::SkiaGLContext::SkiaGLContext):
(WebCore::PlatformDisplay::msaaSampleCount):
* Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp:
(WebCore::SkiaAcceleratedBufferPool::createAcceleratedBuffer):

Canonical link: https://commits.webkit.org/282223@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications