[webkit-changes] [WebKit/WebKit] 7a2d4f: Add 'types' descriptor to the @view-transition rule.

mattwoodrow noreply at github.com
Wed Aug 14 00:28:08 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a2d4f4e88f0f51ac230dce6d25a977d675e50cf
      https://github.com/WebKit/WebKit/commit/7a2d4f4e88f0f51ac230dce6d25a977d675e50cf
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-08-14 (Wed, 14 Aug 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/with-types/at-rule-with-types-parsing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/with-types/types-in-pagereveal-and-pageswap-expected.txt
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSViewTransitionRule.cpp
    M Source/WebCore/css/CSSViewTransitionRule.h
    M Source/WebCore/css/CSSViewTransitionRule.idl
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/dom/ViewTransition.cpp
    M Source/WebCore/dom/ViewTransition.h
    M Source/WebCore/loader/DocumentLoader.cpp

  Log Message:
  -----------
  Add 'types' descriptor to the @view-transition rule.
https://bugs.webkit.org/show_bug.cgi?id=278000
<rdar://133727655>

Reviewed by Tim Nguyen.

@view-transition should support a 'types' descriptor, that then get passed into the cross-document ViewTransition objects.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/with-types/at-rule-with-types-parsing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/with-types/types-in-pagereveal-and-pageswap-expected.txt:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSViewTransitionRule.cpp:
(WebCore::StyleRuleViewTransition::StyleRuleViewTransition):
(WebCore::CSSViewTransitionRule::cssText const):
* Source/WebCore/css/CSSViewTransitionRule.h:
* Source/WebCore/css/CSSViewTransitionRule.idl:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeViewTransitionTypes):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::resolveViewTransitionRule):
(WebCore::Document::reveal):
(WebCore::Document::dispatchPageswapEvent):
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::resolveInboundCrossDocumentViewTransition):
(WebCore::ViewTransition::setTypes):
(WebCore::ViewTransition::createInbound): Deleted.
* Source/WebCore/dom/ViewTransition.h:

Canonical link: https://commits.webkit.org/282221@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list