[webkit-changes] [WebKit/WebKit] deca3c: Web content process may hang under immediate actio...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: deca3c2ef868b7ca7da5a16cb6599584e09dd19b
      https://github.com/WebKit/WebKit/commit/deca3c2ef868b7ca7da5a16cb6599584e09dd19b
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm

  Log Message:
  -----------
  Web content process may hang under immediate action hit testing if PDF plugin has large active selection
https://bugs.webkit.org/show_bug.cgi?id=278013
rdar://125375518

Reviewed by Tim Horton.

When there is a large active selection, for example when a user presses
⌘-A to select all, the web content process hangs in NSAttributedString
operations under PDFPluginBase::dictionaryPopupInfoForSelection().

To address these hangs, we can set an upper bound on the length of the
backing selection string, throwing away the remainder. This is okay to
do because a larger context would not help with the Reveal item created
downstream in WebCore::showPopupOrCreateAnimationController().

* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::dictionaryPopupInfoForSelection):

Canonical link: https://commits.webkit.org/282212@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications