[webkit-changes] [WebKit/WebKit] ab7c5a: Rename lastCharacterIndex to previousCharacterClas...

[Vitor Roriz]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab7c5a4d177e0f3ec2fc75c0f48f8ee552f89399
      https://github.com/WebKit/WebKit/commit/ab7c5a4d177e0f3ec2fc75c0f48f8ee552f89399
  Author: Vitor Roriz <vitor.roriz at apple.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/ComplexTextController.cpp

  Log Message:
  -----------
  Rename lastCharacterIndex to previousCharacterClass for avoiding ambiguity
https://bugs.webkit.org/show_bug.cgi?id=278029
rdar://133772908

Reviewed by Sammy Gill.

There are some ambiguity on the use of the word "last" at ComplexTextController::adjustGlyphsAndAdvances:

- For "isLastCharacter" last means the Nth character in a run of N characters.

- For "lastCharacterIndex" the character we were handling in the previous (last) loop.

We are renaming lastCharacterIndex to previousCharacterIndex for avoiding such ambiguity.

* Source/WebCore/platform/graphics/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

Canonical link: https://commits.webkit.org/282201@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications