[webkit-changes] [WebKit/WebKit] 3b2b06: [Site Isolation] Make setPageScaleFactor async

Commit Queue noreply at github.com
Tue Aug 13 08:51:18 PDT 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b2b06f92fc7a57e191fa92e8e7e826be40319de
      https://github.com/WebKit/WebKit/commit/3b2b06f92fc7a57e191fa92e8e7e826be40319de
  Author: Nitin Mahendru <nitinmahendru at apple.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M LayoutTests/accessibility/tree-update-with-dirty-layout.html
    M LayoutTests/compositing/canvas/hidpi-canvas-backing-store-invalidation-2.html
    M LayoutTests/compositing/geometry/fixed-position-composited-page-scale-down.html
    M LayoutTests/compositing/geometry/fixed-position-composited-page-scale-scroll.html
    M LayoutTests/compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport-expected.html
    M LayoutTests/compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html
    M LayoutTests/compositing/geometry/fixed-position-composited-page-scale.html
    M LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale-down.html
    M LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale.html
    M LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale-down.html
    M LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale.html
    M LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html
    M LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html
    M LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html
    M LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled.html
    M LayoutTests/compositing/overflow/overflow-scaled-descendant-overlapping.html
    M LayoutTests/compositing/repaint/page-scale-repaint.html
    M LayoutTests/compositing/scaling/tiled-layer-recursion.html
    M LayoutTests/css3/filters/backdrop-filter-page-scale-expected.html
    M LayoutTests/css3/filters/backdrop-filter-page-scale.html
    M LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-scaled-expected.html
    M LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-scaled.html
    M LayoutTests/fast/dom/Element/scale-page-bounding-client-rect-in-frame.html
    M LayoutTests/fast/dom/Element/scale-page-bounding-client-rect.html
    M LayoutTests/fast/dom/Element/scale-page-client-rects-in-frame.html
    M LayoutTests/fast/dom/Element/scale-page-client-rects.html
    M LayoutTests/fast/dom/Range/scale-page-bounding-client-rect.html
    M LayoutTests/fast/dom/Range/scale-page-client-rects.html
    M LayoutTests/fast/dom/elementFromPoint-scaled-scrolled-layout-viewport-expected.txt
    M LayoutTests/fast/dom/elementFromPoint-scaled-scrolled-layout-viewport.html
    M LayoutTests/fast/dom/elementFromPoint-scaled-scrolled.html
    M LayoutTests/fast/dom/iframe-inner-size-scaling.html
    M LayoutTests/fast/dom/window-inner-size-scaling-expected.txt
    M LayoutTests/fast/dom/window-inner-size-scaling.html
    M LayoutTests/fast/dom/window-scroll-scaling-expected.txt
    M LayoutTests/fast/dom/window-scroll-scaling.html
    M LayoutTests/fast/events/autoscroll-when-zoomed.html
    M LayoutTests/fast/events/drag-select-when-zoomed-with-header.html
    M LayoutTests/fast/events/drag-select-when-zoomed.html
    M LayoutTests/fast/events/page-scaled-mouse-click-iframe.html
    M LayoutTests/fast/events/page-scaled-mouse-click.html
    M LayoutTests/fast/events/scale-and-scroll-body.html
    M LayoutTests/fast/events/scale-and-scroll-iframe-body.html
    M LayoutTests/fast/events/scale-and-scroll-iframe-window.html
    M LayoutTests/fast/events/scale-and-scroll-window.html
    M LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden.html
    M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-scaled.html
    M LayoutTests/fast/events/touch/page-scaled-touch-gesture-click.html
    M LayoutTests/fast/events/touch/touch-scaled-scrolled.html
    M LayoutTests/fast/frames/frame-set-rotation-hit.html
    M LayoutTests/fast/frames/frame-set-scaling-hit.html
    M LayoutTests/fast/frames/iframe-double-scale-contents.html
    M LayoutTests/fast/repaint/background-scaling.html
    M LayoutTests/fast/repaint/scale-page-shrink.html
    M LayoutTests/fast/scrolling/mac/async-scroll-overflow-rtl-zoomed.html
    M LayoutTests/fast/scrolling/mac/overflow-zoomed-document.html
    M LayoutTests/fast/scrolling/scroll-to-anchor-zoomed-header.html
    M LayoutTests/fast/text/descent-clip-in-scaled-page-expected.html
    M LayoutTests/fast/text/descent-clip-in-scaled-page.html
    M LayoutTests/fast/transforms/selection-bounds-in-transformed-view.html
    M LayoutTests/imported/blink/fast/backgrounds/root-background-with-page-scaled-out-expected.html
    M LayoutTests/imported/blink/fast/backgrounds/root-background-with-page-scaled-out.html
    M LayoutTests/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
    M LayoutTests/scrollingcoordinator/resources/non-fast-scrollable-region-testing.js
    M LayoutTests/svg/as-background-image/tiled-background-image-expected.html
    M LayoutTests/svg/as-background-image/tiled-background-image.html
    M LayoutTests/svg/as-image/image-respects-pageScaleFactor-change.html
    M LayoutTests/svg/as-image/image-respects-pageScaleFactor.html
    M LayoutTests/tiled-drawing/fixed-layout-size-fixed-attachment-cover.html
    M LayoutTests/tiled-drawing/fixed-layout-size-fixed-attachment-local.html
    M LayoutTests/tiled-drawing/header-and-footer-hit-testing-with-page-scale.html
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/C/WKPagePrivate.h
    M Source/WebKit/UIProcess/WebPageProxyTesting.cpp
    M Source/WebKit/UIProcess/WebPageProxyTesting.h
    M Source/WebKit/WebProcess/WebPage/WebPageTesting.cpp
    M Source/WebKit/WebProcess/WebPage/WebPageTesting.h
    M Source/WebKit/WebProcess/WebPage/WebPageTesting.messages.in
    M Tools/DumpRenderTree/TestRunner.cpp
    M Tools/DumpRenderTree/TestRunner.h
    M Tools/DumpRenderTree/mac/TestRunnerMac.mm
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
    M Tools/WebKitTestRunner/TestController.cpp
    M Tools/WebKitTestRunner/TestController.h

  Log Message:
  -----------
  [Site Isolation] Make setPageScaleFactor async
https://bugs.webkit.org/show_bug.cgi?id=277046
rdar://132440505

Reviewed by Alex Christensen and Charlie Wolfe.

Also move it to TestRunner as that seems a better suited place for it. All Layout tests that use this API have been refactored.
I have used whatever strategy possible to not have diffs in the -expected files as much as possible.
That is why some tests are using waitUntilDone and some tests are using jsTestIsAsync.

* LayoutTests/accessibility/tree-update-with-dirty-layout.html:
* LayoutTests/compositing/canvas/hidpi-canvas-backing-store-invalidation-2.html:
* LayoutTests/compositing/geometry/fixed-position-composited-page-scale-down.html:
* LayoutTests/compositing/geometry/fixed-position-composited-page-scale-scroll.html:
* LayoutTests/compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport-expected.html:
* LayoutTests/compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html:
* LayoutTests/compositing/geometry/fixed-position-composited-page-scale.html:
* LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
* LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale.html:
* LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
* LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale.html:
* LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html:
* LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html:
* LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html:
* LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled.html:
* LayoutTests/compositing/overflow/overflow-scaled-descendant-overlapping.html:
* LayoutTests/compositing/repaint/page-scale-repaint.html:
* LayoutTests/compositing/scaling/tiled-layer-recursion.html:
* LayoutTests/css3/filters/backdrop-filter-page-scale-expected.html:
* LayoutTests/css3/filters/backdrop-filter-page-scale.html:
* LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-scaled-expected.html:
* LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-scaled.html:
* LayoutTests/fast/dom/Element/scale-page-bounding-client-rect-in-frame.html:
* LayoutTests/fast/dom/Element/scale-page-bounding-client-rect.html:
* LayoutTests/fast/dom/Element/scale-page-client-rects-in-frame.html:
* LayoutTests/fast/dom/Element/scale-page-client-rects.html:
* LayoutTests/fast/dom/Range/scale-page-bounding-client-rect.html:
* LayoutTests/fast/dom/Range/scale-page-client-rects.html:
* LayoutTests/fast/dom/elementFromPoint-scaled-scrolled-layout-viewport-expected.txt:
* LayoutTests/fast/dom/elementFromPoint-scaled-scrolled-layout-viewport.html:
* LayoutTests/fast/dom/elementFromPoint-scaled-scrolled.html:
* LayoutTests/fast/dom/iframe-inner-size-scaling.html:
* LayoutTests/fast/dom/window-inner-size-scaling-expected.txt:
* LayoutTests/fast/dom/window-inner-size-scaling.html:
* LayoutTests/fast/dom/window-scroll-scaling-expected.txt:
* LayoutTests/fast/dom/window-scroll-scaling.html:
* LayoutTests/fast/events/autoscroll-when-zoomed.html:
* LayoutTests/fast/events/drag-select-when-zoomed-with-header.html:
* LayoutTests/fast/events/drag-select-when-zoomed.html:
* LayoutTests/fast/events/page-scaled-mouse-click-iframe.html:
* LayoutTests/fast/events/page-scaled-mouse-click.html:
* LayoutTests/fast/events/scale-and-scroll-body.html:
* LayoutTests/fast/events/scale-and-scroll-iframe-body.html:
* LayoutTests/fast/events/scale-and-scroll-iframe-window.html:
* LayoutTests/fast/events/scale-and-scroll-window.html:
* LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
* LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-scaled.html:
* LayoutTests/fast/events/touch/page-scaled-touch-gesture-click.html:
* LayoutTests/fast/events/touch/touch-scaled-scrolled.html:
* LayoutTests/fast/frames/frame-set-rotation-hit.html:
* LayoutTests/fast/frames/frame-set-scaling-hit.html:
* LayoutTests/fast/frames/iframe-double-scale-contents.html:
* LayoutTests/fast/repaint/background-scaling.html:
* LayoutTests/fast/repaint/scale-page-shrink.html:
* LayoutTests/fast/scrolling/mac/async-scroll-overflow-rtl-zoomed.html:
* LayoutTests/fast/scrolling/mac/overflow-zoomed-document.html:
* LayoutTests/fast/scrolling/scroll-to-anchor-zoomed-header.html:
* LayoutTests/fast/text/descent-clip-in-scaled-page-expected.html:
* LayoutTests/fast/text/descent-clip-in-scaled-page.html:
* LayoutTests/fast/transforms/selection-bounds-in-transformed-view.html:
* LayoutTests/imported/blink/fast/backgrounds/root-background-with-page-scaled-out-expected.html:
* LayoutTests/imported/blink/fast/backgrounds/root-background-with-page-scaled-out.html:
* LayoutTests/scrollingcoordinator/resources/non-fast-scrollable-region-testing.js:
(async runNonFastScrollableRegionTest):
(runNonFastScrollableRegionTest): Deleted.
* LayoutTests/svg/as-background-image/tiled-background-image-expected.html:
* LayoutTests/svg/as-background-image/tiled-background-image.html:
* LayoutTests/svg/as-image/image-respects-pageScaleFactor-change.html:
* LayoutTests/svg/as-image/image-respects-pageScaleFactor.html:
* LayoutTests/tiled-drawing/fixed-layout-size-fixed-attachment-cover.html:
* LayoutTests/tiled-drawing/fixed-layout-size-fixed-attachment-local.html:
* LayoutTests/tiled-drawing/header-and-footer-hit-testing-with-page-scale.html:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::setPageScaleFactor): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageSetPageScaleFactor):
* Source/WebKit/UIProcess/API/C/WKPagePrivate.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setPageScaleFactor):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setPageScaleFactor):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::requestCookieConsent):
* Tools/DumpRenderTree/TestRunner.cpp:
(setPageScaleFactorCallback):
(TestRunner::staticFunctions):
* Tools/DumpRenderTree/TestRunner.h:
* Tools/DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setPageScaleFactor):
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setPageScaleFactor):
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveAsyncMessageFromInjectedBundle):
(WTR::TestController::setPageScaleFactor):
* Tools/WebKitTestRunner/TestController.h:

Canonical link: https://commits.webkit.org/282170@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list