[webkit-changes] [WebKit/WebKit] 7862f2: [JSC] Simplify ArityFixup

Yusuke Suzuki noreply at github.com
Tue Aug 13 08:27:19 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7862f222fa4e3c695b1e44dd51cd22f1749d6bcb
      https://github.com/WebKit/WebKit/commit/7862f222fa4e3c695b1e44dd51cd22f1749d6bcb
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
    M Source/JavaScriptCore/ftl/FTLCompile.cpp
    M Source/JavaScriptCore/jit/AssemblyHelpers.cpp
    M Source/JavaScriptCore/jit/JIT.cpp
    M Source/JavaScriptCore/jit/JITThunks.cpp
    M Source/JavaScriptCore/jit/JITThunks.h
    M Source/JavaScriptCore/jit/ThunkGenerators.cpp
    M Source/JavaScriptCore/llint/LLIntData.cpp
    M Source/JavaScriptCore/llint/LLIntEntrypoint.cpp
    M Source/JavaScriptCore/llint/LLIntEntrypoint.h
    M Source/JavaScriptCore/llint/LLIntThunks.cpp
    M Source/JavaScriptCore/llint/LLIntThunks.h
    M Source/JavaScriptCore/runtime/JSCConfig.h

  Log Message:
  -----------
  [JSC] Simplify ArityFixup
https://bugs.webkit.org/show_bug.cgi?id=277925
rdar://133619353

Reviewed by Keith Miller.

Let's use tail-call-like form and make ArityFixup significantly simplified.
Instead of doing prologue / epilogue around ArityFixup, just calling it and adjust arity.
And let the other things done in the normal entry point.

* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileFunction):
* Source/JavaScriptCore/ftl/FTLCompile.cpp:
(JSC::FTL::compile):
* Source/JavaScriptCore/jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::getArityPadding):
* Source/JavaScriptCore/jit/JIT.cpp:
(JSC::JIT::compileAndLinkWithoutFinalizing):
* Source/JavaScriptCore/jit/JITThunks.cpp:
* Source/JavaScriptCore/jit/JITThunks.h:
* Source/JavaScriptCore/jit/ThunkGenerators.cpp:
(JSC::arityFixupGenerator): Deleted.
* Source/JavaScriptCore/llint/LLIntData.cpp:
(JSC::LLInt::initialize):
* Source/JavaScriptCore/llint/LLIntEntrypoint.cpp:
(JSC::LLInt::arityFixup):
* Source/JavaScriptCore/llint/LLIntEntrypoint.h:
* Source/JavaScriptCore/llint/LLIntThunks.cpp:
(JSC::LLInt::arityFixupThunk):
* Source/JavaScriptCore/llint/LLIntThunks.h:
* Source/JavaScriptCore/runtime/JSCConfig.h:

Canonical link: https://commits.webkit.org/282167@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list