[webkit-changes] [WebKit/WebKit] 65d48e: [Cleanup] Remove legacy's firstLineBox/lastLineBox

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 65d48e558f2f6190d8d0da5a2a294d365aa8d519
      https://github.com/WebKit/WebKit/commit/65d48e558f2f6190d8d0da5a2a294d365aa8d519
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M Source/WebCore/layout/Verification.cpp
    M Source/WebCore/layout/integration/inline/InlineIteratorInlineBox.cpp
    M Source/WebCore/layout/integration/inline/InlineIteratorLineBox.cpp
    M Source/WebCore/layout/integration/inline/InlineIteratorLineBoxLegacyPath.h
    M Source/WebCore/rendering/LegacyLineLayout.cpp
    M Source/WebCore/rendering/LegacyLineLayout.h
    M Source/WebCore/rendering/RenderBlock.cpp
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderBlockFlow.h
    M Source/WebCore/rendering/RenderFragmentedFlow.cpp
    M Source/WebCore/rendering/RenderInline.cpp
    M Source/WebCore/rendering/RenderInline.h
    M Source/WebCore/rendering/RenderLineBoxList.cpp
    M Source/WebCore/rendering/RenderLineBoxList.h
    M Source/WebCore/rendering/svg/RenderSVGInline.cpp
    M Source/WebCore/rendering/svg/RenderSVGText.cpp
    M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp
    M Source/WebCore/rendering/svg/SVGTextQuery.cpp

  Log Message:
  -----------
  [Cleanup] Remove legacy's firstLineBox/lastLineBox
https://bugs.webkit.org/show_bug.cgi?id=277939

Reviewed by Antti Koivisto.

At this point, legacy has single line content. This patch also adds "legacy" prefix to lineBox (rootBox) which helps to identify redundant usage.
(Sadly while RenderLineBoxList holds a single line box for block container, it still may contain multiple _inline_ boxes for RenderSVGInline, which makes the class interface a bit confusing.)

* Source/WebCore/layout/Verification.cpp:
(WebCore::Layout::collectInlineBoxes):
* Source/WebCore/layout/integration/inline/InlineIteratorInlineBox.cpp:
(WebCore::InlineIterator::firstInlineBoxFor):
(WebCore::InlineIterator::firstRootInlineBoxFor):
* Source/WebCore/layout/integration/inline/InlineIteratorLineBox.cpp:
(WebCore::InlineIterator::firstLineBoxFor):
(WebCore::InlineIterator::lastLineBoxFor):
* Source/WebCore/layout/integration/inline/InlineIteratorLineBoxLegacyPath.h:
(WebCore::InlineIterator::LineBoxIteratorLegacyPath::lineIndex const):
* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::createAndAppendRootInlineBox):
(WebCore::LegacyLineLayout::createLineBoxes):
(WebCore::LegacyLineLayout::constructLine):
(WebCore::repaintSelfPaintInlineBoxes):
(WebCore::LegacyLineLayout::layoutRunsAndFloats):
(WebCore::LegacyLineLayout::layoutLineBoxes):
(WebCore::LegacyLineLayout::addOverflowFromInlineChildren):
(WebCore::LegacyLineLayout::lineCount const):
* Source/WebCore/rendering/LegacyLineLayout.h:
(WebCore::LegacyLineLayout::legacyRootBox const):
(WebCore::LegacyLineLayout::firstRootBox const): Deleted.
(WebCore::LegacyLineLayout::lastRootBox const): Deleted.
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addFocusRingRects const):
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willBeDestroyed):
(WebCore::RenderBlockFlow::inlineBlockBaseline const):
(WebCore::RenderBlockFlow::outputLineTreeAndMark const):
* Source/WebCore/rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::legacyRootBox const):
(WebCore::RenderBlockFlow::firstRootBox const): Deleted.
(WebCore::RenderBlockFlow::lastRootBox const): Deleted.
* Source/WebCore/rendering/RenderFragmentedFlow.cpp:
(WebCore::RenderFragmentedFlow::removeLineFragmentInfo):
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::willBeDestroyed):
(WebCore::RenderInline::generateLineBoxRects const):
(WebCore::RenderInline::firstInlineBoxTopLeft const):
(WebCore::RenderInline::innerPaddingBoxWidth const):
(WebCore::RenderInline::linesBoundingBox const):
(WebCore::RenderInline::linesVisualOverflowBoundingBox const):
(WebCore::RenderInline::clippedOverflowRect const):
(WebCore::RenderInline::offsetForInFlowPositionedInline const):
* Source/WebCore/rendering/RenderInline.h:
(WebCore::RenderInline::legacyLineBox const):
(WebCore::RenderInline::firstLineBox const): Deleted.
(WebCore::RenderInline::lastLineBox const): Deleted.
* Source/WebCore/rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::~RenderLineBoxList):
(WebCore::RenderLineBoxList::appendLineBox):
(WebCore::RenderLineBoxList::deleteLineBoxTree):
(WebCore::RenderLineBoxList::extractLineBox):
(WebCore::RenderLineBoxList::attachLineBox):
(WebCore::RenderLineBoxList::removeLineBox):
(WebCore::RenderLineBoxList::deleteLineBoxes):
(WebCore::RenderLineBoxList::dirtyLineBoxes):
(WebCore::RenderLineBoxList::shiftLinesBy):
(WebCore::RenderLineBoxList::anyLineIntersectsRect const):
(WebCore::RenderLineBoxList::paint const):
(WebCore::RenderLineBoxList::hitTest const):
(WebCore::RenderLineBoxList::dirtyLineFromChangedChild):
(WebCore::RenderLineBoxList::checkConsistency const): Deleted.
* Source/WebCore/rendering/RenderLineBoxList.h:
(WebCore::RenderLineBoxList::legacyLineBox const):
(WebCore::RenderLineBoxList::RenderLineBoxList): Deleted.
(WebCore::RenderLineBoxList::firstLineBox const): Deleted.
(WebCore::RenderLineBoxList::lastLineBox const): Deleted.
(WebCore::RenderLineBoxList::checkConsistency const): Deleted.
* Source/WebCore/rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::absoluteQuads const):
* Source/WebCore/rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::positionForPoint):
* Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeRenderSVGTextBox):
* Source/WebCore/rendering/svg/SVGTextQuery.cpp:
(WebCore::flowBoxForRenderer):

Canonical link: https://commits.webkit.org/282164@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications