[webkit-changes] [WebKit/WebKit] 29fb9a: [Writing Tools] Mail body temporarily disappears w...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29fb9af4daf6d574c95c76bceb58b70372ccb826
      https://github.com/WebKit/WebKit/commit/29fb9af4daf6d574c95c76bceb58b70372ccb826
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-08-12 (Mon, 12 Aug 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.h
    M Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.mm

  Log Message:
  -----------
  [Writing Tools] Mail body temporarily disappears when accepting short form smart reply until questionnaire appears
https://bugs.webkit.org/show_bug.cgi?id=277966
rdar://132910026

Reviewed by Tim Horton.

During the Writing Tools text animation, the text in the session range that has not yet been animated is supposed
to be hidden for the duration of the animation. However, the entire text from the end of the animated range to the
end of the entire document was erroneously being hidden.

As a result, when using Smart Replies, the entire document is hidden during the animation since the session range
is a caret range.

Fix by adjusting the range of the text that is not yet animated to end at the end of the session range instead of
the entire document.

Also, fix some formatting issues, and use the correct types in more places.

* Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.mm:
(WebKit::TextAnimationController::unreplacedRangeForSessionWithID const):
(WebKit::TextAnimationController::contextRangeForTextAnimationID const):
(WebKit::TextAnimationController::removeTransparentMarkersForSessionID):
(WebKit::TextAnimationController::removeInitialTextAnimation):
(WebKit::TextAnimationController::addInitialTextAnimation):
(WebKit::TextAnimationController::addSourceTextAnimation):
(WebKit::TextAnimationController::addDestinationTextAnimation):
(WebKit::TextAnimationController::showSelectionForWritingToolsSessionAssociatedWithAnimationID):
(WebKit::TextAnimationController::updateUnderlyingTextVisibilityForTextAnimationID):
(WebKit::TextAnimationController::clearAnimationsForSessionID):
(WebKit::TextAnimationController::createTextIndicatorForTextAnimationID):

Canonical link: https://commits.webkit.org/282133@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications