[webkit-changes] [WebKit/WebKit] 363d7e: [LFC][IFC] Remove floats that are outside of the "...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 363d7e6b674dc92a23cf41e34737254b0ac81707
      https://github.com/WebKit/WebKit/commit/363d7e6b674dc92a23cf41e34737254b0ac81707
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2024-08-12 (Mon, 12 Aug 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/fast/block/float/intrusive-floats-with-reverted-inline-content-expected.txt
    M LayoutTests/fast/block/float/intrusive-floats-with-reverted-inline-content.html
    M Source/WebCore/layout/floats/PlacedFloats.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  -----------
  [LFC][IFC] Remove floats that are outside of the "rebuild" range to ensure we don't add them twice
https://bugs.webkit.org/show_bug.cgi?id=247625

Reviewed by Alan Baradlay.

When rebuilding a line, we should remove any floats starting from
`lastInlineItemToAdd` up to `layoutRange.endIndex()` from both
`layoutState().placedFloats()` and `m_placedFloats`.

* LayoutTests/TestExpectations:
* LayoutTests/fast/block/float/intrusive-floats-with-reverted-inline-content-expected.txt:
* LayoutTests/fast/block/float/intrusive-floats-with-reverted-inline-content.html:
* Source/WebCore/layout/floats/PlacedFloats.h:
(WebCore::Layout::PlacedFloats::remove):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::rebuildLineWithInlineContent):

Canonical link: https://commits.webkit.org/282129@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications