[webkit-changes] [WebKit/WebKit] f8d516: [GStreamer][WebRTC] Missing capture time in incomi...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8d516f7b7fbb9b9f8e94d3eeecd65b49bcc79e2
      https://github.com/WebKit/WebKit/commit/f8d516f7b7fbb9b9f8e94d3eeecd65b49bcc79e2
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-08-12 (Mon, 12 Aug 2024)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.h
    M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h
    M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp
    M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.h

  Log Message:
  -----------
  [GStreamer][WebRTC] Missing capture time in incoming video frames
https://bugs.webkit.org/show_bug.cgi?id=273026

Reviewed by Xabier Rodriguez-Calvar.

By requesting the underlying rtpbin element to add reference-timestamp-meta information to buffers
we can then retrieve the NTP timestamp corresponding to the RTCP SR timestamp in incoming video
frames. The RTP buffer pad probe was also moved to the IncomingTrackProcessor because that's where
the depayloader is now.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::initializePipeline):
* Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp:
(WebCore::GStreamerIncomingTrackProcessor::incomingTrackProcessor):
(WebCore::GStreamerIncomingTrackProcessor::createParser):
(WebCore::GStreamerIncomingTrackProcessor::installRtpBufferPadProbe):
* Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.h:
* Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h:
* Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp:
(WebCore::RealtimeIncomingVideoSourceGStreamer::setBin): Deleted.
* Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.h:

Canonical link: https://commits.webkit.org/282114@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications