[webkit-changes] [WebKit/WebKit] a0c45c: Don't consider 'fill' a presentation attribute on ...

Commit Queue noreply at github.com
Sun Aug 11 14:44:44 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a0c45ccc4d6a65ce7f2df1f684cfe0abc03f07cd
      https://github.com/WebKit/WebKit/commit/a0c45ccc4d6a65ce7f2df1f684cfe0abc03f07cd
  Author: Ahmad Saleem <ahmad.saleem792 at gmail.com>
  Date:   2024-08-11 (Sun, 11 Aug 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/svg/styling/presentation-attributes-special-cases-expected.txt
    M Source/WebCore/svg/animation/SVGSMILElement.cpp
    M Source/WebCore/svg/animation/SVGSMILElement.h

  Log Message:
  -----------
  Don't consider 'fill' a presentation attribute on animation elements

https://bugs.webkit.org/show_bug.cgi?id=274796
rdar://problem/128896937

Reviewed by Simon Fraser.

Merge: https://chromium-review.googlesource.com/c/chromium/src/+/2080237

This patch aligns WebKit with Gecko / Firefox,
Blink / Chromium and web-specification [1]:

[1] https://svgwg.org/svg2-draft/styling.html#PresentationAttributes

Elements that support the presentation attribute:

"Any element in the SVG namespace except for animation elements,
which have a different ‘fill’ attribute."

* Source/WebCore/svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::hasPresentationalHintsForAttribute const):
* Source/WebCore/svg/animation/SVGSMILElement.h:
* LayoutTests/imported/w3c/web-platform-tests/svg/styling/presentation-attributes-special-cases-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/282100@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list