[webkit-changes] [WebKit/WebKit] cd1755: [css-color] Implement color-layers() (without blen...

Tim Nguyen noreply at github.com
Sat Aug 10 19:57:40 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd1755d8a2fc5ca111e84a250d28dbdb2cd1a218
      https://github.com/WebKit/WebKit/commit/cd1755d8a2fc5ca111e84a250d28dbdb2cd1a218
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-08-10 (Sat, 10 Aug 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-layers-no-blend-mode-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-layers-no-blend-mode-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-layers-no-blend-mode.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-layers-function-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-layers-function.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-layers-function-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-layers-function.html
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSValueKeywords.in
    A Source/WebCore/css/color/CSSColorLayersResolver.cpp
    A Source/WebCore/css/color/CSSColorLayersResolver.h
    A Source/WebCore/css/color/CSSColorLayersSerialization.h
    M Source/WebCore/css/color/CSSUnresolvedColor.h
    A Source/WebCore/css/color/CSSUnresolvedColorLayers.cpp
    A Source/WebCore/css/color/CSSUnresolvedColorLayers.h
    M Source/WebCore/css/color/StyleColor.cpp
    M Source/WebCore/css/color/StyleColor.h
    A Source/WebCore/css/color/StyleColorLayers.cpp
    A Source/WebCore/css/color/StyleColorLayers.h
    M Source/WebCore/css/parser/CSSParserContext.cpp
    M Source/WebCore/css/parser/CSSParserContext.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp

  Log Message:
  -----------
  [css-color] Implement color-layers() (without blend mode support)
https://bugs.webkit.org/show_bug.cgi?id=277837
rdar://133499954

Reviewed by Sam Weinig.

This implements rendering & syntax for color-layers(<color>#) where the list of colors is ordered from top to bottom (like background layers).

https://drafts.csswg.org/css-color-6/#color-layers

Preliminary piping for the optional <blend-mode> parameter is also added, though the parsing code is commented out until rendering is implemented.

* LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-layers-no-blend-mode-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-layers-no-blend-mode-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-layers-no-blend-mode.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-layers-function-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-layers-function.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-layers-function-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-layers-function.html: Added.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/color/CSSColorLayersResolver.cpp: Added.
(WebCore::blendSourceOver):
* Source/WebCore/css/color/CSSColorLayersResolver.h: Added.
* Source/WebCore/css/color/CSSColorLayersSerialization.h: Added.
(WebCore::serializationForCSSColorLayers):
* Source/WebCore/css/color/CSSUnresolvedColor.h:
* Source/WebCore/css/color/CSSUnresolvedColorLayers.cpp: Added.
(WebCore::serializationForCSS):
(WebCore::createStyleColor):
(WebCore::createColor):
(WebCore::containsCurrentColor):
(WebCore::containsColorSchemeDependentColor):
* Source/WebCore/css/color/CSSUnresolvedColorLayers.h: Added.
* Source/WebCore/css/color/StyleColor.cpp:
(WebCore::StyleColor::StyleColor):
(WebCore::StyleColor::visit):
(WebCore::StyleColor::copy):
* Source/WebCore/css/color/StyleColor.h:
* Source/WebCore/css/color/StyleColorLayers.cpp: Added.
(WebCore::resolveAbsoluteComponents):
(WebCore::resolveColor):
(WebCore::containsNonAbsoluteColor):
(WebCore::containsCurrentColor):
(WebCore::serializationForCSS):
(WebCore::operator<<):
* Source/WebCore/css/color/StyleColorLayers.h: Added.
(WebCore::operator==):
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::add):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp:
(WebCore::CSSPropertyParserHelpers::consumeColorLayersFunction):
(WebCore::CSSPropertyParserHelpers::consumeAColorFunction):

Canonical link: https://commits.webkit.org/282094@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list